Thanks to you Maxim. I've tried more than once to fix the problem with the query limit but it's seams to have quite a low threshold. Anyway, in .travis.yml file there are the encrypted Google map credentials we use in the unit tests. They are defined as global environment variables
On Tue, Jun 26, 2018, 1:14 PM Maxim Solodovnik <[email protected]> wrote: > The build seems to be fixed > Thanks a lot for the help :) > > On Tue, Jun 26, 2018 at 3:48 PM Maxim Solodovnik <[email protected]> > wrote: > > > Ignored for now > > We need to invent some better solution > > > > On Tue, Jun 26, 2018 at 2:48 PM Martin Grigorov <[email protected]> > > wrote: > > > >> This test fails too often. > >> I'd suggest to @Ignore it. > >> > >> On Tue, Jun 26, 2018 at 10:34 AM Maxim Solodovnik <[email protected] > > > >> wrote: > >> > >> > Just have noticed: both builds fail due to > >> > GeocoderException: OVER_QUERY_LIMIT > >> > How can I check which credentials are being used by this test? > >> > > >> > On Sat, Jun 23, 2018 at 3:16 AM Andrea Del Bene <[email protected] > > > >> > wrote: > >> > > >> > > I've found something that might be interesting. Java 10 contains a > fix > >> > > about Calendar#getFirstDayOfWeek(): > >> > > > >> > > https://bugs.openjdk.java.net/browse/JDK-8185841 > >> > > > >> > > To get the first day of the week DatePicker uses the following code: > >> > > > >> > > protected int getFirstDayOfWeek(Locale locale) > >> > > { > >> > > return Calendar.getInstance(locale).getFirstDayOfWeek() - 1; > >> > > } > >> > > > >> > > This code produces 0 (Sunday) as first day of the week for the > Italian > >> > > locale we use in the test, but the right value should be 1 (Monday). > >> > > This explains why it fails expecting 'START_WEEKDAY:1'. So I guess > now > >> > > we should remove ' - 1' from the previous code. > >> > > > >> > > On 22/06/2018 15:06, Andrea Del Bene wrote: > >> > > > I don't know if the two things are related (they don't look to > me), > >> > > > but yesterday I've refactored Wicket 9 to remove many deprecated > >> > > > classes from wicket-core. You can try to run the build locally > >> > > > updating the 9.0.0-SNAPSHOT dependencies. > >> > > > > >> > > > On Fri, Jun 22, 2018 at 2:35 PM, Maxim Solodovnik > >> > > > <[email protected] <mailto:[email protected]>> wrote: > >> > > > > >> > > > Both failed :( > >> > > > > >> > > > WBR, Maxim > >> > > > (from mobile, sorry for the typos) > >> > > > > >> > > > On Fri, Jun 22, 2018, 18:15 Maxim Solodovnik < > >> [email protected] > >> > > > <mailto:[email protected]>> wrote: > >> > > > > >> > > > > Was able to run the build with 2 java10: > >> > > > > https://travis-ci.org/wicketstuff/core > >> > > > <https://travis-ci.org/wicketstuff/core> > >> > > > > Lets check the results :) > >> > > > > > >> > > > > On Fri, Jun 22, 2018 at 5:30 PM Andrea Del Bene > >> > > > <[email protected] <mailto:[email protected]>> > >> > > > > wrote: > >> > > > > > >> > > > >> Maybe the type of JDK is irrelevant but still, that's what > I > >> > > > noted so > >> > > > >> far... > >> > > > >> > >> > > > >> On Fri, Jun 22, 2018 at 12:27 PM, Maxim Solodovnik > >> > > > <[email protected] <mailto:[email protected]>> > >> > > > >> wrote: > >> > > > >> > >> > > > >> > Travis has OpenJDK, will add OracleJDK to compare :) > >> > > > >> > > >> > > > >> > On Fri, Jun 22, 2018 at 5:26 PM Andrea Del Bene > >> > > > <[email protected] <mailto:[email protected]>> > >> > > > >> > wrote: > >> > > > >> > > >> > > > >> > > Hi, > >> > > > >> > > > >> > > > >> > > build fails on my local machine with the same error. > I've > >> > > > successfully > >> > > > >> > > build the project few days ago on another machine. On > the > >> > > > failing > >> > > > >> machine > >> > > > >> > > I've got an Oracle JDK while on the other one I have an > >> > > OpenJDK > >> > > > >> > > distribution. I will try to investigate further as soon > >> as > >> > > > possible. > >> > > > >> > > > >> > > > >> > > On Fri, Jun 22, 2018 at 11:44 AM, Maxim Solodovnik < > >> > > > >> [email protected] <mailto:[email protected]> > >> > > > >> > > > >> > > > >> > > wrote: > >> > > > >> > > > >> > > > >> > > > Hello All, > >> > > > >> > > > > >> > > > >> > > > I have build failed for wicketstuff/master after > >> > > > switching to Java10 > >> > > > >> > > > > >> > > > >> > > > Here is the error: > >> > > > >> > > > > >> > > > >> > > > [ERROR] > test1(org.wicketstuff.datetime.extensions.yui. > >> > > > >> > > > calendar.DatePickerTest) > >> > > > >> > > > Time elapsed: 0.269 s <<< FAILURE! > >> > > > >> > > > org.junit.ComparisonFailure: > >> > > > >> > > > org/wicketstuff/datetime/extensions/yui/calendar/ > >> > > > >> > > > DatesPage1_ExpectedResult.html > >> > > > >> > > > > >> > > > expected:<...ato"],START_WEEKDAY:[1],WEEKDAYS_1CHAR:["d"...> > but > >> > > > >> > > > > was:<...ato"],START_WEEKDAY:[0],WEEKDAYS_1CHAR:["d"...> > >> > > > >> > > > at > >> > org.wicketstuff.datetime.extensions.yui.calendar. > >> > > > >> > > > > DatePickerTest.myTestExecution(DatePickerTest.java:761) > >> > > > >> > > > at > >> > org.wicketstuff.datetime.extensions.yui.calendar. > >> > > > >> > > > DatePickerTest.test1(DatePickerTest.java:75) > >> > > > >> > > > > >> > > > >> > > > Changing DatesPage1_ExpectedResult.html doesn't help > >> > > > >> > > > > >> > > > >> > > > it fails with the error > >> > > > >> > > > > >> > > > >> > > > > >> > > > expected:<...ato"],START_WEEKDAY:[0],WEEKDAYS_1CHAR:["d"...> > but > >> > > > >> > > > > was:<...ato"],START_WEEKDAY:[1],WEEKDAYS_1CHAR:["d"...> > >> > > > >> > > > > >> > > > >> > > > > >> > > > >> > > > Could someone please take a look at it? > >> > > > >> > > > > >> > > > >> > > > build works as expected on my local machine > >> > > > >> > > > > >> > > > >> > > > > >> > > > >> > > > -- > >> > > > >> > > > WBR > >> > > > >> > > > Maxim aka solomax > >> > > > >> > > > > >> > > > >> > > > >> > > > >> > > >> > > > >> > > >> > > > >> > -- > >> > > > >> > WBR > >> > > > >> > Maxim aka solomax > >> > > > >> > > >> > > > >> > >> > > > > > >> > > > > > >> > > > > -- > >> > > > > WBR > >> > > > > Maxim aka solomax > >> > > > > > >> > > > > >> > > > > >> > > > >> > > > >> > > >> > -- > >> > WBR > >> > Maxim aka solomax > >> > > >> > > > > > > -- > > WBR > > Maxim aka solomax > > > > > -- > WBR > Maxim aka solomax >
