Hi all, following the discussion about the issues related to the building of 7.11.0 candidate, I suggest to do the following actions:
-cancel this vote -remove the flag '--allow-script-in-comments' from JavaDoc plugin configuration -extend the existing java8 profile activating it by default if our default JDK is 1.8 or higher (with expresion '[1.8,)'). I now this solution won't work for all 1.8 versions out there, but it should with most recent versions of it. Honestly I can't find a better solution to make everybody happy. This solution will NOT work only if somebody is using an outdated version of JDK 1.8 as default JDK, but it should be ok in all the other cases. -...any suggestions? On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <[email protected]> wrote: > The error is something like: > "Invalid parameter --allow-script-in-comments" and javadoc will fail > > It looks like java8 profile is activated, I was sure it shouldn't since > java7 was selected using toolchains ... > > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <[email protected]> > wrote: > > > Hi Maxim > > > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <[email protected]> > > wrote: > > > > > Hello Andrea, > > > > > > according to my tests this is not working if toolchains plugin is being > > > used, i.e.: > > > 1) java8 is set on the machine as default > > > 2) -Pbuildbot is used to activate java7 build > > > Result: java8 profile will be activated > > > > > > > > > > > that's quite strange. Do you remember which error did you get with this > > combination? I've searched through old mails but I didn't find it. > Anyway, > > flag '--allow-script-in-comments' is supported in JDK 8 only starting > from > > u121: > > > > > https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html > > > > > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <[email protected]> > > > wrote: > > > > > > > I see that Maxim has already addressed this problem with WICKET-6615, > > or > > > > at least he partially did it. We should use a profile which is > > > > automatically activated when the JDK used to run Maven is >= 1.8 . > > > > Something like this: > > > > > > > > <profile> > > > > <id>java8</id> > > > > <activation> > > > > <jdk>[1.8,)</jdk> > > > > </activation> > > > > <build> > > > > <pluginManagement> > > > > <plugins> > > > > <plugin> > > > > <groupId>org.apache.maven.plugins</groupId> > > > > <artifactId>maven-javadoc-plugin</artifactId> > > > > <configuration> > > > > <additionalparam>--allow-script-in-comments</additionalparam> > > > > </configuration> > > > > </plugin> > > > > </plugins> > > > > </pluginManagement> > > > > </build> > > > > </profile> > > > > > > > > A similar solution is described here: > > > > > > > > > > > > > > > > > > https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete > > > > > > > > WDYT? > > > > > > > > > > > > > For me the build of > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz > > > > > fails with: > > > > > > > > > > [INFO] > > > > > > > > > ------------------------------------------------------------------------ > > > > > [INFO] BUILD FAILURE > > > > > [INFO] > > > > > > > > > ------------------------------------------------------------------------ > > > > > [INFO] Total time: 11.773 s > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00 > > > > > [INFO] > > > > > > > > > ------------------------------------------------------------------------ > > > > > [ERROR] Failed to execute goal > > > > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar > > > > (attach-javadocs) > > > > > on project wicket-util: MavenReportException: Error while > generating > > > > > Javadoc: > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag: > > > > > --allow-script-in-comments > > > > > [ERROR] > > > > > [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc > > > > -J-Xmx256m > > > > > -J-Xms128m @options @packages > > > > > [ERROR] > > > > > [ERROR] Refer to the generated Javadoc files in > > > > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir. > > > > > > > > > > My JDK 7 doesn't like the the newly added javadoc argument. > > > > > > > > > > java version "1.7.0_72" > > > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14) > > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode) > > > > > > > > > > > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene < > > [email protected]> > > > > > wrote: > > > > > > > > > >> This is a vote to release Apache Wicket 7.11.0 > > > > >> > > > > >> Please download the source distributions found in our staging area > > > > >> linked below. > > > > >> > > > > >> I have included the signatures for both the source archives. This > > vote > > > > >> lasts for 72 hours minimum. > > > > >> > > > > >> [ ] Yes, release Apache Wicket 7.11.0 > > > > >> [ ] No, don't release Apache Wicket 7.11.0, because ... > > > > >> > > > > >> Distributions, changelog, keys and signatures can be found at: > > > > >> > > > > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0 > > > > >> > > > > >> Staging repository: > > > > >> > > > > >> > > > > >> > > > > https://repository.apache.org/content/repositories/orgapachewicket-1115 > > > > >> > > > > >> The binaries are available in the above link, as are a staging > > > > >> repository for Maven. Typically the vote is on the source, but > > should > > > > >> you find a problem with one of the binaries, please let me know, I > > can > > > > >> re-roll them some way or the other. > > > > >> > > > > >> Staging git repository data: > > > > >> > > > > >> Repository: [email protected]:bitstorm/wicket.git > > > > >> Branch: build/wicket-7.11.0 > > > > >> Release tag: rel/wicket-7.11.0 > > > > >> > > > > >> > > > > >> > > > > ======================================================================== > > > > >> > > > > >> The signatures for the source release artefacts: > > > > >> > > > > >> > > > > >> Signature for apache-wicket-7.11.0.zip: > > > > >> > > > > >> -----BEGIN PGP SIGNATURE----- > > > > >> > > > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT > > > > >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/ > > > > >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z > > > > >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV > > > > >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF > > > > >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky > > > > >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE > > > > >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu > > > > >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c > > > > >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9 > > > > >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye > > > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA= > > > > >> =WU+g > > > > >> -----END PGP SIGNATURE----- > > > > >> > > > > >> Signature for apache-wicket-7.11.0.tar.gz: > > > > >> > > > > >> -----BEGIN PGP SIGNATURE----- > > > > >> > > > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT > > > > >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp > > > > >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1 > > > > >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM > > > > >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49 > > > > >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3 > > > > >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u > > > > >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6 > > > > >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW > > > > >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD > > > > >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd > > > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0= > > > > >> =rLlH > > > > >> -----END PGP SIGNATURE----- > > > > >> > > > > >> > > > > ======================================================================== > > > > >> > > > > >> CHANGELOG for 7.11.0: > > > > >> > > > > >> ** Bug > > > > >> > > > > >> * [WICKET-6473] - Double slash break 404page > > > > >> * [WICKET-6533] - Error while parsing xml using AjaxButton > > > > >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with > > > HTML > > > > >> comments > > > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly > > at > > > > >> Weblogic > > > > >> * [WICKET-6553] - SelectOptions doesn't html-encode option > > values > > > > >> * [WICKET-6564] - PageStoreManager#clear() does not > completely > > > > clear > > > > >> * [WICKET-6568] - Wicket fails / does not encode request > header > > > > >> values in AjaxCalls > > > > >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in > > > > >> JavaScriptPackageResource > > > > >> * [WICKET-6589] - ClientInfo fails with NumberFormatException > > for > > > > >> unusual browser versions > > > > >> * [WICKET-6604] - Ajax repaint is not correctly handled when > > > > >> component being repainted has an enclosure associated with it and > is > > > > >> not a child of the enclosure > > > > >> * [WICKET-6614] - AbstractRangeValidator looks up string with > > the > > > > >> wrong key if locale is Turkish > > > > >> > > > > >> ** Improvement > > > > >> > > > > >> * [WICKET-6527] - no possibility to override fixed html > > appended > > > > >> directly to response by FilterForm > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless > > > > >> > > > > >> ** Task > > > > >> > > > > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in > > Component > > > > >> urges to use redirectTo method when in a constructor > > > > >> > > > > > > > > > > > > > -- > > > WBR > > > Maxim aka solomax > > > > > > > > > -- > > Andrea Del Bene. > > Apache Wicket committer. > > > > > -- > WBR > Maxim aka solomax > -- Andrea Del Bene. Apache Wicket committer.
