This vote passes.Thank you all!
On 07/12/18 03:58, Maxim Solodovnik wrote:
+1
checksums/signatures OK (old format, hard to check)
Build under Oracle jdk1.6.0_45 fail as-is
Build is Ok after commenting/removing '--allow-script-in-comments'
On Fri, 7 Dec 2018 at 03:13, Martin Grigorov <[email protected]> wrote:
+1 to release
I've downloaded zulu6.22.0.3-jdk6.0.119-linux_x64 and now everything is
fine if I run Maven 3.6.0 with Java 8 and toolchains pointing to Zulu 6.
On Thu, Dec 6, 2018 at 1:21 PM Andrea Del Bene <[email protected]>
wrote:
Hi,
I forgot to remove the commit from 6.x branch. The well-known
'--allow-script-in-comments' flag has been introduced for Oracle JDK 6
with
build 1.6.0_141-b12. I wrongly assumed that OpenJDK followed the same
update train, so I used OpenJDK 6 u119 from Azul, which actually contains
the support for the flag. That's why I haven't noted any problem. I can
remove the commit as Martin suggested and I successfully executed the
build
process with an older OpenJDK build 31 taken from here:
https://github.com/alexkasko/openjdk-unofficial-builds. I know it's not
an
official distribution but it really saved me a lot of time and I can't
find
a better solution.
On Thu, Dec 6, 2018 at 11:53 AM sven <[email protected]> wrote:
+1 to release
Successfully built with Maven 3.5.3 on Java 1.8.0
I've had a lot of troubles with building any Wicket version recently,
we
should definitely improve the situation for all branches.
This one worked fine though
Sven
--
Andrea Del Bene.
Apache Wicket committer.
