[GitHub] wicket pull request #283: Wicket-6563 page store implementation

[svenmeier]

Github user svenmeier commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/283#discussion_r240608325
  
    --- Diff: 
wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java ---
    @@ -167,6 +168,10 @@ protected IPageStore newPersistentStore()
                Bytes maxSizePerSession = storeSettings.getMaxSizePerSession();
                File fileStoreFolder = storeSettings.getFileStoreFolder();
     
    -           return new DiskPageStore(application.getName(), 
fileStoreFolder, maxSizePerSession, getSerializer());
    +           if (storeSettings.isEncrypted()) {
    --- End diff --
    
    This is a question of CoR vs a collection, like 
https://stackoverflow.com/questions/1055383/what-are-the-advantages-of-chain-of-responsibility-vs-lists-of-classes
    
    I prefer the former, since it gives more power to each store, e.g. 
GroupingPageStore has to control delegation to the next store.
    I don't think configurability is a huge issue, since page stores are pretty 
static once set up.


---