+1 to make it deprecated and correct the documentation I'm also OK with removing it in 9.0.0, I believe there is enough time to fix 9.0.0 applications :)
On Wed, 23 Jan 2019 at 05:28, Andrea Del Bene <an.delb...@gmail.com> wrote: > + 1 to rework the documentation. EnclosureContainer should be the > recommended way. I'm not sure if we should completely remove > <wicket:enclosure>,but we should definitely make clear that it is not > suited for all use cases. > > On 22/01/19 13:36, Martin Grigorov wrote: > > Hi, > > > > At > > > https://issues.apache.org/jira/browse/WICKET-6622?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=16748665#comment-16748665 > > a user suggests something that I like: to rework the documentation [1] to > > use EnclosureContainer instead of <wicket:enclosure>. > > > > if we want to keep some documentation about <wicket:enclosure> then it > > should have a warning next to it saying that it doesn't work in some > corner > > cases. > > > > WDYT ? > > > > Martin > > > > 1. > > > https://ci.apache.org/projects/wicket/guide/8.x/single.html#_hiding_decorating_elements_with_the_wicket_enclosure_tag > > > -- WBR Maxim aka solomax
