ivaynberg commented on issue #361: WICKET-6666 initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492058445 > I believe that some abstract component such as AbstractModalDialog should be created in core to represent dialogs, it could be squeezed in as a base class for existing ModalWindow and maybe for this new one, to make it easier to switch between implementations. Potentially this abstract component can have some very basic JS with enough hooks and callbacks so it can easily be extended with other wicket extensions or replaced completely. > I doubt that is possible. Each dialog works in fundamentally different ways, so a base class makes little sense. The only reason why a separate class exists is to make migration easier, eventually ModalWindow will be removed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
