I haven't checked it absence of other data produces errors My intend was to fix NPE Will try to check if any other issues will arise
On Wed, 29 May 2019 at 13:23, Martin Grigorov <[email protected]> wrote: > Hi Maxim, > > On Wed, May 29, 2019 at 7:19 AM Maxim Solodovnik <[email protected]> > wrote: > > > Hello All, > > > > Today I tried to use RequestCycle.get().urlFor(...) from a thread started > > around heavy task > > (I have preserved Application, Session and RequestCycle in ThreadContext) > > > > Surprisingly I got NPE due to `Request.getClientUrl()` was throwing NPE > or > > was `null` and caused NPE > > > > I would like to modify [1] to preserve original clientUrl and return it > > > > What about all other methods ? > > https://github.com/apache/wicket/blob/a4b92a4322ec00832afc2fdbe2d885ca476ba6c5/wicket-request/src/main/java/org/apache/wicket/request/Request.java#L164-L197 > > > > > > Would it be OK? > > Does it worth PR? > > > > [1] > > > > > https://github.com/apache/wicket/blob/master/wicket-request/src/main/java/org/apache/wicket/request/Request.java#L190 > > > > -- > > WBR > > Maxim aka solomax > > > -- WBR Maxim aka solomax
