svenmeier opened a new pull request #375: WICKET-6666 modal dialog URL: https://github.com/apache/wicket/pull/375 This is my take on a new modal dialog/window for Wicket. I've taken Igor's work as a base but changed a lot of things, so I thought a separate pull-request would be easier to digest: - JavaScript All JavaScript is optional now, ModalDialog works without Ajax too. We can safely leave the dialog's markup where it is, no need to move it around. If people want to have the markup somewhere else, they can add the dialog somewhere else (see Java below). JS enhancements (like trap-focus) are located in Wicket behaviors, allowing people to substitute their own solution. - CSS I've reorganized the CSS into a theme like we have for several other components. It is changed now to respect the size of the dialog's content. This leaves all customizing to the user, no need for Wicket to get involved (see examples below). - Java No need to fiddle with forms (see JavaScript above). Full support for nesting. In my experience many projects like to have a single container on each page to host lazily created dialogs, I've added AjaxListPanel for that. I like the #open(Componente, ART) method, to open a single dialog with different contents. But users like to subclass dialogs to use them from different places, thus we need a #setContent(Component) method too. - Examples I've extended the ModalDialogPage example to show-off all new features.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
