svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303079004
########## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ########## @@ -152,28 +155,48 @@ public static void writeJavaScriptUrl(final Response response, final CharSequenc public static void writeJavaScriptUrl(final Response response, final CharSequence url, Review comment: These method have to much arguments already: Just give it an IValueMap and write all out to the tag. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services