svenmeier commented on issue #378: WICKET-6688 add RFC support (to avoid unsafe eval) URL: https://github.com/apache/wicket/pull/378#issuecomment-518701345 I've taken a second look and I'm all in favor of pursuing this improvement. #appendJavaScript() and #appendRemoteFunctionCall() could be unified into a single method: target.appendJavaScriptCall("Window.eval", "Wicket.Ajax.ajax{...}"); target.appendJavaScriptCall("Wicket.Ajax.RFC.testFunc1", "something2", 1); But more importantly, in this current state of the proposal any Ajax refresh of any component breaks immediately due to blocking of eval(). Either we have to put much more effort into this and adapt most of Wicket's JS or this change is worthless.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
