svenmeier commented on a change in pull request #380: WICKET-6558 no lock after
detach
URL: https://github.com/apache/wicket/pull/380#discussion_r314034503
##########
File path:
wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
##########
@@ -495,12 +494,21 @@ public void clearFeedbackMessages()
*/
protected void cleanupFeedbackMessages(IFeedbackMessageFilter filter)
{
- ApplicationSettings applicationSettings =
application.getApplicationSettings();
- IFeedbackMessageFilter old =
applicationSettings.getFeedbackMessageCleanupFilter();
- applicationSettings.setFeedbackMessageCleanupFilter(filter);
- getLastRenderedPage().detach();
- getSession().detach();
- applicationSettings.setFeedbackMessageCleanupFilter(old);
+
Review comment:
We cannot detach the session, otherwise it will block access to its page
manager afterwards. Actually detachment isn't needed anyways, just the message
have to be cleared. For symmetry don't call detach on components either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
