seminolas commented on issue #380: WICKET-6558 no lock after detach URL: https://github.com/apache/wicket/pull/380#issuecomment-521456564 Looks good to me. We had some custom logging asking for the name of the page class after the session had already been detached. We only noticed it in production with locked page exceptions - this would have made debugging much easier. @svenmeier I wonder if you can comment on why we only saw it very rarely. My theory was to do with unmounted pages: most of our pages are mounted and presumably resolving the page class uses some shortcut in code - without requiring a page lock. Resolving the name for unmounted pages does require a lock and caused the LockedPage exception on subsequent request. Does that sound reasonable? Our current fix only disables that (unnecessary) bit of logging -- and it seems to work -- but I wonder if I'm merely fixing a symptom of the real issue.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
