martin-g commented on a change in pull request #380: WICKET-6558 no lock after
detach
URL: https://github.com/apache/wicket/pull/380#discussion_r315000147
##########
File path: wicket-core/src/main/java/org/apache/wicket/Session.java
##########
@@ -915,6 +924,10 @@ public int nextPageId()
*/
public final IPageManager getPageManager()
{
+ if
(Boolean.TRUE.equals(RequestCycle.get().getMetaData(PAGES_UNLOCKED))) {
+ throw new WicketRuntimeException("pages have already
been unlocked - synchronized access is no longer possible");
Review comment:
I am not sure how understandable this message would be for the average
developer. Maybe something like "The request [cycle] has been processed. Access
to the pages is no more allowed" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
