martin-g commented on a change in pull request #382: WICKET-6688 add RFC and
replace eval with DOM eval
URL: https://github.com/apache/wicket/pull/382#discussion_r322734084
##########
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##########
@@ -1007,10 +1026,32 @@
}
},
+ /**
+ * execute Remote Function Call (RFC) with no eval
+ * @param context {Object} - the object that brings the
executer's steps and the attributes
+ * @param node {Element} - the <[priority-]rfc> element with
the script to evaluate
+ */
+ processRemoteFunctionCall: function(context, node) {
+ // get the javascript body
+ var text = Wicket.DOM.text(node);
+ var functions = JSON.parse(text);
+ for (var f = 0; f < functions.length; f++) {
+ /**
+ * @type {{func: string, args: []}}
Review comment:
are the extra curly braces needed ? they confuse me a bit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
