This vote is canceled. Thanks to Sebastien for spotting a problem with
this built!
On 9/8/19 3:59 PM, Sven Meier wrote:
Hi Sebastien,
I've fiddled with priority header item ordering, see:
[WICKET-6673] - PriorityHeaderItem ordering is wrong for siblings
Your code probably depends on the prior erroneous ordering.
I'll take a look.
Sven
Am 8. September 2019 14:44:38 MESZ schrieb Sebastien Briquet
<[email protected]>:
Unfortunately, I did not spot the problem exactly...
It is related with JavaScriptResourceReference dependencies render
order.
I have a ConsoleJavaScriptResourceReference which extends
JQueryPluginResourceReference
JQueryPluginResourceReference does have dependency on
JQueryResourceReference.
ConsoleJavaScriptResourceReference is rendered with PriorityHeader.
in -M3, ConsoleJavaScriptResourceReference is rendered before
JQueryResourceReference (whereas it should not be the case due to the
dependency), leading to a "ReferenceError: jQuery is not defined" in
the
browser's console.
It works as expected in -M2 and 8.6.0 (and since several years
actually).
The funny thing is that I have severral other RRs extending
JQueryPluginResourceReference, all work as expected, except this very
one.
And I really do not see what could be different with that one!
I do not have time today to try to isolate the issue in a quickstart,
so if
someone would like to play around:
$ git clone https://github.com/sebfz1/wicket-jquery-ui.git
$ git checkout wicket9.x
$ mvn clean install
$ cd wicket-jquery-ui-samples
$ mvn jetty:run
go to
http://localhost:8080/wicket-jquery-ui/kendo/console/DefaultConsolePage
and
check the console...
Thanks and best regards,
Sebastien
On Sun, Sep 8, 2019 at 1:39 PM Andrea Del Bene <[email protected]>
wrote:
No problem for me. We can keep the vote open for two-three days more.
On Sun, Sep 8, 2019, 12:31 PM Sebastien Briquet <[email protected]>
wrote:
Hi Andrea,
Can you please wait a little before closing the vote? I may have a
slight
issue with this one (that does not repro with 8.6.0), but I'm not
sure
yet
where it come from...
Sorry for the late notice (hard to find some spare time especially
during
weekdays...)
Thanks in advance,
Sebastien
On Wed, Sep 4, 2019 at 10:16 PM Andrea Del Bene
<[email protected]>
wrote:
This is a vote to release Apache Wicket 9.0.0-M3
Please download the source distributions found in our staging
area
linked below.
I have included the signatures for both the source archives. This
vote
lasts for 72 hours minimum.
[ ] Yes, release Apache Wicket 9.0.0-M3
[ ] No, don't release Apache Wicket 9.0.0-M3, because ...
Distributions, changelog, keys and signatures can be found at:
https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M3
Staging repository:
https://repository.apache.org/content/repositories/orgapachewicket-1129
The binaries are available in the above link, as are a staging
repository for Maven. Typically the vote is on the source, but
should
you find a problem with one of the binaries, please let me know,
I can
re-roll them some way or the other.
Staging git repository data:
Repository: [email protected]:bitstorm/wicket.git
Branch: build/wicket-9.0.0-M3
Release tag: rel/wicket-9.0.0-M3
========================================================================
The signatures for the source release artefacts:
Signature for apache-wicket-9.0.0-M3.zip:
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl1wGtAACgkQh48B+qjT
VuEVoQ/6A1UQE/g2XFweih85oBMsUJZe2O+AHxpZ+xcrFvvGLX/Wn0MxqtB7bBra
2G7iIiF5ojRiBRxh5s3S3S+eQwGqhevPRUiQCTJNznzBZJvNWO6/8+d4Id4Fs9qr
LNl5CjZ3DQNZc9vjAe393SWxJUvhQMfTJPn+jObarGmTVU9M6vi3TC3y/eTOihH6
D2TARlkT64oR4SCfNqFUNec9h1qEfqHNccG1I43pYaAKPb1cw/84XR3vvwF8cU3S
dPRP2qh3ki6p4LrVbkbi64gkVb7GyNXuiYNftrA2SVgcnoBR486HJtMujWz77z6h
Wc0wC30yIE7Uf1vbqOBJiowD6FvAnP+ZLXQ1iwBnGPUu/2b0r6yjxuvGOm6fHQ5/
8DWdJkOlOIdOU4LucG7uo5Z97rRzYuTtv9bOwkDBf/UDYvOaJtHc2cAca2On6fjw
hdvVNQ3CTHOeq3PpofRw0OFaxbOOkb7rOieh1AbfkXbn2MpwQTFVZI8G3l8u9M4R
WhlsuF2S3dwQ0CbnVvHfdKzlnAsNt6tnaQv2N64Nxoubwur6TcHJ1VDMh0hVhAAV
IoTfVtG+eEpoXuW4nHtenJWlWUaH4isv6+USibb48VZq4qTC1TRtOTqhUCP3G1oA
ctfBDHcFnK9mJSHMIu/UB4eRfZuuBWoQX65m/rO0M86gakEVjTA=
=Skwp
-----END PGP SIGNATURE-----
Signature for apache-wicket-9.0.0-M3.tar.gz:
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl1wGtAACgkQh48B+qjT
VuGsqBAAiRpOCAMGjwgcHOk19gKgjzzAJ6hBJJyMLinWQnD5VNttWiEFFbm92KC+
qRm6lWEnBR7xwgrn5m0evcqYiOuNjr1cHuAFdHfOGJkuubsfy/K1MCG6DI7d7M2A
mv5sQJdFzMGLqCvqMzypou5CCHfIZr9FejG9FMEOIU8aHqGIgQJgpOHfQvYVxUFl
75MCA4e180JlwLnxdvvkunomT1alhmVTdXRLiC+EzPQsSydlyeUNFGvmEBoeqEX7
NgEFfVE3fr0uxyStzftCiMHwaQpt91d1dJ5MIgAM8xboWGB/6KqA/nE5T9/FkTS6
5B4HjIHULKEpwP1e+dqB5kHJO7pK7rJbj1JnE42+bbmd3GiSDNFlZX7FkIlUhwYS
RDv2gkfX1j2DtH/2ZnS/K/ACjgWpMPkbIpPKFOtH8JMjKi/RegVLUPRQYxdlj65K
8SNxnMpzjoMlN5U3HDw/+ShZHO/NcabLelGtCCwpQdSY2PLI4JGuqDMefR1Lu20v
AMExkuNo+WOL2oForlH6jhbbUu/GVJ/GnD/4OJ7drEhBeGu1FeS78n59LNidzeKc
Xg/WPhsEi1wez0I/Y1vudwMK/ChT4GTxoxQKyIhSgYOYtot9aSbc7D/04eSvCdcB
Td1+ZqvqUFkTs0VxCOxLmxg9vesQvNcqi2Sd96desqeUZOHt3HU=
=0ALV
-----END PGP SIGNATURE-----
========================================================================
CHANGELOG for 9.0.0-M3:
** Bug
* [WICKET-6613] - Wicket 8.1 ModalWindow autosizing problem
* [WICKET-6676] - Quickstart application won't deploy to
GlassFish
* [WICKET-6678] - Instant : Unsupported field: YearOfEra
when
cookieUtils.cookieToDebugString() is called
* [WICKET-6680] - JavaScriptStripper chokes on template
literals
that contain two forward slashes
* [WICKET-6689] - ClientProperties.getTimeZone() has some
issue
when DST and UTC offsets are different
* [WICKET-6690] - NullPointerException in
KeyInSessionSunJceCryptFactory.<init>
* [WICKET-6692] - Page deserialization on websocket close -
possible performance issue
* [WICKET-6697] - Wicket.DOM.toggleClass JS method is
missing
** New Feature
* [WICKET-6559] - Encrypted page store
** Improvement
* [WICKET-6558] - Prevent package locks after commitRequest
* [WICKET-6672] - Restore constructors with Wicket Duration
in 9.x
branch for easier migration
* [WICKET-6673] - PriorityHeaderItem ordering is wrong for
siblings
* [WICKET-6675] - log4j-slf4j-impl requires version 1.7.25
of
slf4j-api while Wicket 8.5 requires version 1.7.26
* [WICKET-6682] - Improve JavaScriptContentHeaderItem and
JavaScriptUtils to support nonce
* [WICKET-6683] - triggered events should bubble
* [WICKET-6684] - Make autolabel functionality more flexible
by
introducing a locator interface that allows to specify the
component
the
wicket:for refers to
* [WICKET-6693] - Mark FormComponent#setModelValue(String[])
as
not
being part of the public API
* [WICKET-6695] - Add AjaxEditable*Label#shouldTrimInput()
* [WICKET-6696] - Unify AjaxEditable*#getConverter()
