svenmeier commented on a change in pull request #384: WICKET-6703 replace eval
with jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#discussion_r328924409
##########
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##########
@@ -350,6 +350,44 @@
*/
Wicket.Ajax.Call = Wicket.Class.create();
+ Wicket.Ajax.Call._suspended = 0;
+
+ Wicket.Ajax.Call.currentNotify = undefined;
+
+ Wicket.Ajax.Call.suspend = function () {
+ if (typeof (Wicket.Ajax.Call.currentNotify) != "function") {
+ Wicket.Log.error("Can't suspend: no evaluation in
process");
+ return;
+ }
+ Wicket.Ajax.Call._suspended++;
+ var notify = Wicket.Ajax.Call.currentNotify;
+ var released = false;
+
+ return function () {
+ // release only once
+ if (released === false) {
+ released = true;
+ Wicket.Ajax.Call._suspended--;
+ if (Wicket.Ajax.Call._suspended === 0) {
+ notify();
+ }
+ }
+ }
+ };
+
+ Wicket.Ajax.Call.getFunctionsExecuterStatus = function() {
+ if (Wicket.Ajax.Call._suspended) {
+ // suspended
+ return FunctionsExecuter.ASYNC;
+ } else {
+ // execution finished, cleanup the last notify
+ Wicket.Ajax.Call.currentNotify = undefined;
Review comment:
currentNotify has to be cleared in either case, there's no need to keep it
around any longer. Either a suspension was aquired at this point or not.
Actually we have to move the _suspended counter into the scope of
currentNotify, otherwise we run intro troubles with parallel Ajax requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
