dawidss7 commented on a change in pull request #386: WICKET-6531 Crash in
Unsafe.getObject when running on the J9 VM
URL: https://github.com/apache/wicket/pull/386#discussion_r332837909
##########
File path:
wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
##########
@@ -235,6 +235,9 @@ public String toString()
{
try
{
+
+ available = "Oracle
Corporation".equals(System.getProperty("java.vm.vendor")); //WICKET-6531
Review comment:
I checked this on several different VMs an operating systems and i don't
think we can tell if there is an Oracle vm or not.
`java.specification.vendor` is always `Oracle Corporation`
ORACLE JAVA 8 - UBUNTU
java.specification.vendor = Oracle Corporation
java.vendor = Oracle Corporation
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Oracle Corporation
ORACLE JAVA 8 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Oracle Corporation
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Oracle Corporation
ORACLE JAVA 10 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Oracle Corporation
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = "Oracle Corporation"
AMAZON CORRETTO 11 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Amazon.com Inc.
java.vm.name = OpenJDK 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Amazon.com Inc.
IBM JDK 8 - AIX
java.specification.vendor = Oracle Corporation
java.vendor = IBM Corporation
java.vm.name = IBM J9 VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = IBM Corporation
OPENJDK J9 8 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Eclipse OpenJ9
java.vm.name = Eclipse OpenJ9 VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Eclipse OpenJ9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
