martin-g commented on a change in pull request #396: Wicket 6712 js time zone
URL: https://github.com/apache/wicket/pull/396#discussion_r340442504
##########
File path:
wicket-core/src/main/java/org/apache/wicket/markup/html/pages/wicket-browser-info.js
##########
@@ -58,6 +58,8 @@
info.screenHeight =
window.screen.height;
info.screenColorDepth =
window.screen.colorDepth;
}
+ var jsTimeZone =
Intl.DateTimeFormat().resolvedOptions().timeZone
Review comment:
According to
https://caniuse.com/#feat=mdn-javascript_builtins_intl_datetimeformat_resolvedoptions
this would fail on Android devices. Let's add some `isDefined` checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
