+1

kind regards

Tobias

> Am 25.11.2019 um 11:15 schrieb Andrea Del Bene <an.delb...@gmail.com>:
> 
> I don't think it's possible to test JREs at minor version level, unless
> using some kind of custom annotation. So I guess we should adapt our test
> for the last version after asking infra folks to upgrade the current JDK 11
> used by Buildbot.
> 
>> On Mon, Nov 25, 2019 at 6:18 AM Tobias Soloschenko
>> <tobiassolosche...@googlemail.com.invalid> wrote:
>> 
>> I think the tests are fine (to also test UTC) I would just have a look if
>> it is also possible to check the jdk on builds and if not just write the
>> tests for the newest Version and fix the test to check against UTC.
>> 
>> That was the reason why the bug was found. :-)
>> 
>> kind regards
>> 
>> Tobias
>> 
>>>> Am 25.11.2019 um 05:17 schrieb Maxim Solodovnik <solomax...@gmail.com>:
>>> 
>>> Maybe it worth to update tests so they will not rely on JDK default date
>>> format?
>>> 
>>> 
>>>> On Mon, 25 Nov 2019 at 04:27, Andrea Del Bene <an.delb...@gmail.com>
>> wrote:
>>>> 
>>>> And I think it was backported here:
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8228473
>>>> 
>>>>> On 11/23/19 11:18 PM, Tobias Soloschenko wrote:
>>>>> Martin also asked if the fix is downported from JDK 13 to 12 / 11 and
>> it
>>>> is a bit more complicated
>>>>> 
>>>>> kind regards
>>>>> 
>>>>> Tobias
>>>>> 
>>>>>> Am 23.11.2019 um 22:35 schrieb Sven Meier <s...@meiers.net>:
>>>>>> 
>>>>>> Hi Andrea,
>>>>>> 
>>>>>> confirmed!
>>>>>> 
>>>>>> Sven
>>>>>> 
>>>>>>> On 23.11.19 18:57, Andrea Del Bene wrote:
>>>>>>> Hi,
>>>>>>> 
>>>>>>> I've just found that with the last OpenJDK 11.0.5 taken from
>>>> AdoptOpenJDK I'm not able to build master branch as the following test
>>>> fails:
>>>>>>> 
>>>>>>> [ERROR] Failures:
>>>>>>> [ERROR] ZonedDateTimeConverterTest.convertToObject_java12Minus:50
>>>> expected: <2016-07-11T01:02:03Z[Etc/UCT]> but was:
>>>> <2016-07-11T01:02:03Z[Etc/UTC]>
>>>>>>> 
>>>>>>> I suspect is the same problem found some time ago by Martin:
>>>>>>> 
>>>>>>> https://markmail.org/message/g5cbnw47kt7yrj7t
>>>>>>> 
>>>>>>> Could you confirm this problem.
>>>>>>> 
>>>>>>> Thank you.
>>>>>>> 
>>>>>>> Andrea.
>>>>>>> 
>>>> 
>>> 
>>> 
>>> --
>>> WBR
>>> Maxim aka solomax
>> 
> 
> 
> -- 
> Andrea Del Bene.
> Apache Wicket committer.

Reply via email to