svenmeier commented on issue #375: WICKET-6666 modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-569816088 Hi @chrisco484, thanks for chiming in. Yes, I have used ModalX before. I like that you can show arbitrary dialogs without the need to keep them in the component tree prematurely. I'm not a big fan of the ModalMgr interface and other details though, but these might stem from the fact ModalX uses the old clumsy ModalWindow in the first place. And I don't think imposing any superclass or interface on pages is a bad idea, since Wicket pages have to much responsibility anyway. I've seen many projects doing the same with their own implementation that keeps central 'pool' of dialogs somewhere in the component hierarchy. How this pool is managed has to be decided by each project individually. Note how the example ModalDialogPage uses the new AjaxListPanel to do something similar but more generally: https://github.com/apache/wicket/blob/a1a6206c30c1f388ec9c3ec32139addb8979c768/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/modal/ModalDialogPage.java#L188 IMHO this serves the same purpose. Please share your thoughts on what might still be missing or could be improved.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
