+1 to release!

Tested local build and various Wicket Examples.

Great work with CSP and the new ModalWindow !


One minor issue in the examples:
The new SRI demo does not work for me.

It shows this text in the page:

SRI Demo

Integrity test NOT passed

and it has the following error in browser's DevTools > Console:

Failed to find a valid digest in the 'integrity' attribute for resource '
http://localhost:8080/we/sri/wicket/resource/org.apache.wicket.examples.sri.IntegrityDemoPage/subresource-ver-9819D5B70B2A0640EBBD29C052AECF77.js'
with computed SHA-256 integrity
'hks0S2euGLdFJuhD/PFNYo9fb6RZn2qmM9Hrml9Oob4='. The resource has been
blocked.

On Sun, Jan 5, 2020 at 5:10 PM Andrea Del Bene <[email protected]> wrote:

> This is a vote to release Apache Wicket 9.0.0-M4
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 9.0.0-M4
> [ ] No, don't release Apache Wicket 9.0.0-M4, because ...
>
>
> IMPORTANT NOTE
> JDK 11.0.5 has backported a change for UTC rappresentation that breaks
> our test
> classorg.apache.wicket.util.convert.converter.ZonedDateTimeConverterTest.
> An earlier version of JDK 11 is therefore required to build this release
> from source.
> The test code will be updated with the next release.
>
> Distributions, changelog, keys and signatures can be found at:
>
>      https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M4
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-1136/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
>      Repository:  [email protected]:bitstorm/wicket.git
>      Branch:      build/wicket-9.0.0-M4
>      Release tag: rel/wicket-9.0.0-M4
>
>
> ========================================================================
>
>      The signatures for the source release artefacts:
>
>
> Signature for apache-wicket-9.0.0-M4.zip:
>
>      -----BEGIN PGP SIGNATURE-----
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl4R85kACgkQh48B+qjT
> VuGntA//Xf4wa16S6ebZCcywSg3eHBJMJfq9bBheHcPJIWr6orfAA55ATRJsblon
> qcfwVX6R8+hgNuvDZBr5kilzos4uPG50d3QxK1dkZ5bu9cRXuytVzCP7TqIEUJ4U
> mY/vER9XrRI0JdHwnsnoiom6Nms7ftf2z9AS1xmTnUgUW9lon6yHNBDcMS7fmQWR
> QbHQQA9PE+AVyTieQ46iVTidBxoOsiqbPJAib+TbTQKMNcUypOZiqEJMBGGiVsf+
> 76Jg5OUmgPxWEbRiw/A3e80rV+TrCH/LCdpY9FjckTbK/6wFfv47aMBt4ODeODc3
> uu+KAK8dWGEQ0DgtTEMEtndqsL989QKH+AFAQbnNQIvf9J0vFZBAJzWMFV0dOHgt
> eTEcU6Di5JPOYDDEjptAQ4aP8Oet620k0hXFSAUrmJlCYM3DzhW0cVAxCVpZR99k
> 6fZjIwAJUGOLISKYFRHfkqq2iAs1mlbr9KfU+XXUeOv8rtdyhqySL1HaWugdONPb
> 2cvXFmWpiX1SUht+7IvMIJFHYJcXVRfZz7H4VcP9m33tcsfGgIM3AcwjoH8baPrH
> 01nD5gpTKR8uTuu3BAS/G3+hA7s2mLJ+uKTOYp4mhNzgSYIpl8vOJu5SX/2eru3E
> m3NGWCJuc8yY8ovY9cVdYhvdfUfrvZzB2om3TVFK749fBjxx/GY=
> =Bzfw
> -----END PGP SIGNATURE-----
>
> Signature for apache-wicket-9.0.0-M4.tar.gz:
>
>      -----BEGIN PGP SIGNATURE-----
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl4R85gACgkQh48B+qjT
> VuF2OA//YxW8XfR1fj3Xt4Y8MhKVjzbs0POPSmr/FHSn9hJrKK3UCo+7PZ3IY9vv
> fxx44jjyyeASLUcezqRJwpkdGO69/HIYngn1q/QDxXxX0zmQZDGl5lWtVZlipU0v
> VZvzSjVTu65viQn3Vc+v5qdsbsvLrGiMdafok3q3fdC8TTe/1adaF1m7TTDoLI08
> PvN6IIKiC3c5XmT9NYyIFI/EUeyAvmQpdFar3hsFvBQfGZi1ODWPubD4r3BW+Ylx
> NmALy1WLt8uqB9MMkTeU/BQeek1sskz70JP56mFbHaOinISB4jxLNYYW4t7lrg2N
> Hh22r3FlzR+4L8VJO5vUJH2OXiMPP0vGWHWMAXxl0KIXGpd7RGHJIDJnLC3pVxYn
> bNWAKcDmdG7beBkKVIB4uT/8bvTdDZI/DPUMA8qAxLEawJwMtqcfXJSaeITDyuIG
> XZVRro3jw3pyzYDnFAwY/YoJVOjJXGCspKz/bb/+0cU0AFS+a/Z6RSK9BixtguXs
> WBBuXFAnqdSCb9ulS9sX7rp3lPHtGHyhnbPzP3o3CJq2nCkOMxscRtKESgmy4yDW
> 7z/ELoSoMUqAzm9dpYGBL78VYmZ91MtevMQtTJ8xENXvhWyL0dxbQJ78ED2hDS2N
> hT3NHdbzM30YT6hskECkdHALc1yLe/Fdiiqn/1qHoQSqGHJvr1I=
> =h6KN
> -----END PGP SIGNATURE-----
>
> ========================================================================
>
>      CHANGELOG for 9.0.0-M4:
>
> ** Bug
>
>      * [WICKET-6531] - Crash in Unsafe.getObject when running on the J9 VM
>      * [WICKET-6704] - JavaSerializer.serialize causes the JVM crash !
>      * [WICKET-6706] - Websocket Endpoint logs exception when user
> leaves page
>      * [WICKET-6707] - Property setter parameter type is assumed to be
> equal to getter return type
>      * [WICKET-6708] - FormComponent should read only the GET/POST
> parameters of the request, not both
>      * [WICKET-6713] - BaseWicketTester does not reset componentInPage
> field
>      * [WICKET-6717] - Automatic-Module-Name should be valid Java
> identifier
>
> ** New Feature
>
>      * [WICKET-6666] - Rewrite ModalWindow
>
> ** Improvement
>
>      * [WICKET-3404] - Improve ModalWindow form handling
>      * [WICKET-6321] - Support Integrity and Crossorigin attributes for
> JavaScriptUrlReferenceHeaderItem
>      * [WICKET-6682] - Improve JavaScriptContentHeaderItem and
> JavaScriptUtils to support nonce
>      * [WICKET-6701] - DownloadLink make content disposition configurable
>      * [WICKET-6703] - Eliminate window.eval from wicket-ajax-jquery
>      * [WICKET-6709] - Cache the value of WebRequest#isAjax()
>      * [WICKET-6712] - Timezone can be determined on client side
>      * [WICKET-6714] - Please add better getResource-Support for
> MockServletContext
>      * [WICKET-6718] - AjaxFormChoiceComponentUpdatingBehavior uses
> "click" instead of "change"
>      * [WICKET-6720] - ConcatBundleResource#getResourceStream should not
> eagerly fetch resources
>
>

Reply via email to