theigl commented on issue #411: WICKET-6751 Page synchronizer strategies URL: https://github.com/apache/wicket/pull/411#issuecomment-595135207 @martin-g: Thanks for reviewing! I'll push the requested changes asap. What do you think about this issue from my PR description: > I'm not sure if PageLock is in the right place now. It is still a static inner class of PageAccessSynchronizer but it is only used by DefaultLockManager and can be used by custom lock manager implementations. It would probably be better to make it a top-level class. Should we keep it in `PageAccessSynchronizer` even though it is not used by the class anymore? Instead of making it a top-level class, I could also move it to `DefaultLockManager`. This probably makes the most sense.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
