theigl commented on a change in pull request #417: WICKET-6761 Multiple
websocket connections from the same session
URL: https://github.com/apache/wicket/pull/417#discussion_r395979705
##########
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/BaseWebSocketBehavior.java
##########
@@ -93,10 +119,12 @@ public void renderHead(Component component,
IHeaderResponse response)
int pageId = component.getPage().getPageId();
variables.put("pageId", pageId);
variables.put("resourceName", "");
+ variables.put("resourceToken", "");
Review comment:
@martin-g: My reasoning was this: Pages already work with multiple tabs
because the connection key contains the `pageId` with is unique it to each tab
as far as I understand. We could pass it for pages as well and add it to the
key but it wouldn't really improve things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
