On Tue, Mar 31, 2020 at 6:06 PM Martin Grigorov <[email protected]> wrote:
> I've found a problem with the default impl for #detach() method of > IRequestablePage and IRequestableComponent. > In Java everything is OK but my Scala application fails with: > > INFO] --- scala-maven-plugin:4.3.1:compile (default) @ presentation --- > [INFO] Using incremental compilation using JavaThenScala compile order > [INFO] Compiler bridge file: > /home/martin/.sbt/1.0/zinc/org.scala-sbt/org.scala-sbt-compiler-bridge_2.13-1.3.2-bin_2.13.1__58.0-1.3.2_20200115T025827.jar > [INFO] Compiling 91 Scala sources and 27 Java sources to > /home/martin/git/myscalaapp/target/classes ... > [ERROR] [Error] > /home/martin/git/myscalaapp/src/main/scala/com/mycompany/myscalaapp/pages/MainPage.scala:65: > cannot override final member: > final def detach#12140(): Unit#1311 (defined in class Component#7657) > with <defaultmethod> def detach#12448(): Unit#1311 (defined in trait > IRequestablePage#11471) > [ERROR] [Error] > /home/martin/git/myscalaapp/src/main/scala/com/mycompany/myscalaapp/pages/HomePage.scala:8: > cannot override final member: > final def detach#12140(): Unit#1311 (defined in class Component#7657) > with <defaultmethod> def detach#12448(): Unit#1311 (defined in trait > IRequestablePage#11471) > [ERROR] two errors found > > It looks like a problem in the Scala compiler but it would take some time > to convince the Scala team to fix it. > I will revert my recent changes in this area! > Done! > > Martin > > > On Tue, Mar 31, 2020 at 1:47 PM Martin Grigorov <[email protected]> > wrote: > >> >> On Tue, Mar 31, 2020 at 10:49 AM Andrea Del Bene <[email protected]> >> wrote: >> >>> ready, steady....Martin? :-) >>> >> >> Go ahead! >> >> >>> >>> On 3/31/20 8:58 AM, Sven Meier wrote: >>> > Hi Maxim, >>> > >>> > I'd say all changes are complete :). >>> > >>> > Have fun >>> > Sven >>> > >>> > On 30.03.20 08:23, Maxim Solodovnik wrote: >>> >> Hello All, >>> >> >>> >> Are there any incomplete tasks yet? >>> >> Shall we start new VOTE? :))) >>> >> >>> >> On Mon, 9 Mar 2020 at 16:56, Ernesto Reinaldo Barreiro >>> >> <[email protected]> >>> >> wrote: >>> >> >>> >>> Hahaha... as always Martin is too fast :-) >>> >>> >>> >>> On Mon, Mar 9, 2020 at 10:40 AM Maxim Solodovnik < >>> [email protected]> >>> >>> wrote: >>> >>> >>> >>>> Martin commited method rename yesterday :) >>> >>>> >>> >>>> On Mon, 9 Mar 2020 at 15:35, Ernesto Reinaldo Barreiro >>> >>>> <[email protected]> wrote: >>> >>>>> -1: Thanks Martin. After your comment I just remember Adrea >>> mentioned >>> >>>>> refactoring settings for new CSP feature to be aligned with other >>> >>> wicket >>> >>>>> settings. >>> >>>>> >>> >>>>> On Sun, Mar 8, 2020 at 6:57 AM Martin Grigorov < >>> [email protected]> >>> >>>> wrote: >>> >>>>>> On Sat, Mar 7, 2020 at 2:06 PM Andrea Del Bene < >>> [email protected] >>> >>>>>> wrote: >>> >>>>>> >>> >>>>>>> +1 >>> >>>>>>> For the 9.0.0-M5 I guess, the other versions dont have much new >>> >>>>>> material. I >>> >>>>>>> wanted to rework CSP configuration a little bit but I didn't have >>> >>>> much >>> >>>>>>> spare time to do it. I can postpone it after M5. >>> >>>>>>> >>> >>>>>> Please wait a bit with the release. >>> >>>>>> Everyone hopes that we will release .Final after M5. >>> >>>>>> I will do some changes now. >>> >>>>>> >>> >>>>>> >>> >>>>>>> On Sat, Mar 7, 2020, 10:31 AM Ernesto Reinaldo Barreiro < >>> >>>>>>> [email protected]> >>> >>>>>>> wrote: >>> >>>>>>> >>> >>>>>>>> +1 >>> >>>>>>>> >>> >>>>>>>> On Sat, Mar 7, 2020 at 5:14 AM Maxim Solodovnik < >>> >>>> [email protected]> >>> >>>>>>>> wrote: >>> >>>>>>>> >>> >>>>>>>>> subj :) >>> >>>>>>>>> >>> >>>>>>>>> -- >>> >>>>>>>>> WBR >>> >>>>>>>>> Maxim aka solomax >>> >>>>>>>>> >>> >>>>>>>> >>> >>>>>>>> -- >>> >>>>>>>> Regards - Ernesto Reinaldo Barreiro >>> >>>>>>>> >>> >>>>> >>> >>>>> -- >>> >>>>> Regards - Ernesto Reinaldo Barreiro >>> >>>> >>> >>>> >>> >>>> -- >>> >>>> WBR >>> >>>> Maxim aka solomax >>> >>>> >>> >>> >>> >>> -- >>> >>> Regards - Ernesto Reinaldo Barreiro >>> >>> >>> >> >>> >>
