martin-g commented on a change in pull request #440:
URL: https://github.com/apache/wicket/pull/440#discussion_r466333061
##########
File path:
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
##########
@@ -1711,7 +1725,7 @@ public final void writeHiddenFields()
{
// if it's a get, did put the parameters in the action
attribute,
// and have to write the url parameters as hidden fields
- if (encodeUrlInHiddenFields())
+ if (METHOD_POST.equalsIgnoreCase(getMethod()))
Review comment:
I've updated it.
I want to check what else could be simplified by using always hidden fields.
I don't see a reason to write extra query parameters in the form action url
instead of using hidden fields everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
