martin-g commented on a change in pull request #442:
URL: https://github.com/apache/wicket/pull/442#discussion_r469106265



##########
File path: 
wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java
##########
@@ -1111,4 +1115,14 @@ public ContentSecurityPolicySettings getCspSettings()
                }
                return cspSettings;
        }
+
+       public void enableCoop(CoopConfiguration coopConfig)

Review comment:
       How about this idea:
   - add the CoopConfiguration and CoepConfiguration as fields in 
SecuritySettings.
   - add third mode `DISABLED` to the existing ones (`ENFORCING` and 
`REPORTING`)
   - in Application#initApplication() add some logic to auto-add the Coop/Coep 
listener(s) when they are enabled
   
   This way the developer will have to configure the security settings and 
don't bother how they are applied.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to