bitstorm commented on pull request #462: URL: https://github.com/apache/wicket/pull/462#issuecomment-778842092
With my commit I've tried to bring in some ideas to make Wicket more independent from the specific solution currently adopted (a password-based DES cypher): - I've created a new class GenericJceCrypt, which should serve as base class to implement a specific JCE chyper. This class is meant to replace AbstractCrypt in Wicket 10. - I've also created class AbstractKeyInSessionCryptFactory to provide a base class to store a session relative key used for URL encryption. Again, the current class KeyInSessionSunJceCryptFactory only supports password based algorithms. The new class should simplify the implementation of session crypt factories that use more complex values as key (for exemple a javax.crypto.SecretKey). - Finally I've deprecated ICyper#setKey because it supports just string key and (IMHO) in any case it shouldn't be partof the API contract. Let me know what you think about this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
