reiern70 commented on pull request #467:
URL: https://github.com/apache/wicket/pull/467#issuecomment-816488695


   > IMHO OnFileSelectedBehavior deserves to be a top-level class. Maybe with 
its own JS resource, since the script to collect dynamicExtraParameters is 
getting very long now.
   > 
   > With a static factory method users could use a lambda expression (like we 
have for several other behaviors, e.g. AjaxFormSubmitBehavior#onSubmit):
   > 
   > ```
   > file.add(OnFileSelectedBehavior.onSelected((AjaxRequestTarget target, 
List<OnFileSelectedBehavior.FileDescription> fileDescriptions) -> {
   >     // ...
   > }));
   > ```
   > 
   > Maybe drop the "On"-prefix too, since almost all current behaviors don't 
have it - are you doing Android development? ;)
   
   
![image](https://user-images.githubusercontent.com/462655/114146955-2ffde300-98e6-11eb-9a92-91e27adb2243.png)
   
   I see a lot of 'On' hanging around. Thus unless there is a very strong 
opinion about it from most of the developers I will keep it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to