reiern70 commented on pull request #471: URL: https://github.com/apache/wicket/pull/471#issuecomment-850792867
> I've build a lot of these components over the years for different projects, and each had to be different according to the needs of the current project. > > There are a whole lot of issues with this implementation, from less important ones like documentation and coding style to larger conceptual errors, performance considerations and code duplication. > > I'd rather not pull this code chunk into Wicket as is, and restructuring it might take a long time. I fully agree. IMHO. this does not belong to core wicket. At least not in its current state. If cleaned, interfaces and concepts clearly defined it can be maybe added to wicket-stuff. I also had to create similar components for customer projects and I do not think it is that easy to roll a "fit all use cases component". **Side note**: when creating these kinds of PR it is very useful to attach some images thus that reviewers can easily see how this component looks like. Thanks for your efforts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
