On Sat, Jun 12, 2021 at 1:25 AM Lon Varscsak <[email protected]> wrote:
> It was a documented case, here's what Sven told me several years ago (maybe > it has since been "fixed"): > > "this is a known problem with TransparentWebMarkupContainers, see > > WICKET-5479 > WICKET-5479 is about Enclosure. Yes, we know that Enclosures have problems! As I recommended in the ticket you better use EnclosureContainer instead of <div wicket:enclosure> or <wicket:enclosure> > > You should use a WebMarkupContainer and #queue() instead." > > > I can create a test case though. > If you have a test case without Enclosure then please share it and explain what problem you face! > > On Thu, Jun 10, 2021 at 11:31 PM Martin Grigorov <[email protected]> > wrote: > > > Hi Lon, > > > > On Fri, Jun 11, 2021 at 7:08 AM Lon Varscsak <[email protected]> > > wrote: > > > > > I find it useful as well. Also, there is a situation where queue is > > > required (as far as I can tell) and that's when you're subclassing > > > something with <wicket:extend> doing an "add" on the subclass throws an > > > error because it can't be found in markup. "queue" makes that > situation > > > work. Maybe there's another way to handle that...I'm not sure. > > > > > > > This should just work with add(). > > If you can reproduce it then please share it with us and we will take a > > look! > > > > > > > > > > -Lon > > > > > > On Wed, Jun 9, 2021 at 5:14 PM Justin Mclean <[email protected]> > wrote: > > > > > > > Hi, > > > > > > > > I'm not on your PMC but I took a quick look at this release and > noticed > > > > that the contents of LICENSE and NOTICE don't follow the guidance > here. > > > [1] > > > > In particular included 3rd party licenses are not listed in LICENSE > and > > > the > > > > NOTICE file contains MIT and BSD license information when it probably > > > > shouldn't. there might however be a reason you are doing it this way > > > that > > > > I'm not aware of. > > > > > > > > I can also see some fonts in your release that may not be under a > > license > > > > that is compatible with the Apache license. > > > > > > > > You might want to review these couple of things next time you make a > > > > release. > > > > > > > > Kind Regards, > > > > Justin > > > > > > > > 1. https://infra.apache.org/licensing-howto.html > > > > > > > > > >
