Could please create PR at wickestuff with version 6? I will be happy to drop other versions for master (wicket-10)
Ill try to do a review (but unfortunately don't have much time, so i can do only 1-2 reviews per week) Hopefully others can help :) Thanks in advance for contribution :) from mobile (sorry for typos ;) On Thu, Jul 13, 2023, 19:23 Johannes Renoth <johan...@renoth.dev> wrote: > Hi all, > > First of all: Thanks for providing continued support and even further > development for Wicket. > > Now to my questions: > > Since Wicketstuff only has TinyMCE until version 4 but this version has > some serious vulnerabilites https://security.snyk.io/package/npm/tinymce > and the version used in wicketstuff is really old (4.3.4) i have begun > to implement a Wicket-Integration of trumbowyg > https://alex-d.github.io/Trumbowyg/ and > https://github.com/renoth/wicket-trumbowyg > > I already have a maven nexus account to release artifacts on maven > central, but before i do this i have some questions > > Do you plan to update Tinymce to latest version? > > Is there an alternative already implemented? > > Would you be interested in integrating the code into wicketstuff? If > yes, would you do a code review? > > The plugin structure of trumbowyg is somewhat finegrained and there is > some serious loading of lots of js and css files necessary at the moment > see > > https://github.com/renoth/wicket-trumbowyg/blob/master/src/main/java/dev/renoth/trumbowyg/TrumboWygBehavior.java#L70-L107, > > maybe someone has an idea how to improve it to only need one request per > JS and CSS in total > > Other than that i works great with a quickstart. > > Thank you for your time, > > Johannes Renoth > > > >
