dashorst opened a new issue, #1658: URL: https://github.com/apache/wicket/issues/1658
The quickstart archetype's `pom.xml` moved to Jetty 12 in WICKET-7199 (`jetty.version` 12.1.14 with `jetty-ee11-webapp` and `jetty-ee11-websocket-jakarta-server` on master, 12.1.12 with the `ee10` artifacts on wicket-10.x), but `src/test/java/Start.java` still uses the Jetty 11 API: ```java import org.eclipse.jetty.server.session.DefaultSessionCache; import org.eclipse.jetty.server.session.FileSessionDataStore; import org.eclipse.jetty.servlet.ServletContextHandler; import org.eclipse.jetty.webapp.WebAppContext; import org.eclipse.jetty.websocket.jakarta.server.config.JakartaWebSocketServletContainerInitializer; ``` In Jetty 12 these classes live in other packages (`org.eclipse.jetty.session`, `org.eclipse.jetty.ee11.webapp`, `org.eclipse.jetty.ee11.servlet`, `org.eclipse.jetty.ee11.websocket.jakarta.server.config`), so a project generated from the archetype on master or wicket-10.x does not compile its test sources: `mvn test` fails, and so does starting the application with `Start`. The 10.11.0 archetype still uses Jetty 11 and is not affected. `Start.java` also imports `org.apache.wicket.protocol.ws.javax.WicketServerEndpointConfig`, which is worth checking in the same go. Proposed fix: port `Start.java` to the Jetty 12 ee11 (master) and ee10 (wicket-10.x) API, and add a build step that generates a project from the archetype and compiles it, so a dependency update cannot break the quickstart unnoticed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
