dashorst opened a new issue, #1699: URL: https://github.com/apache/wicket/issues/1699
`build-changelog.sh` builds the release notes for `CHANGELOG-<major>.x` from Apache Jira only. It looks up the Jira version id for the release in project WICKET (id 12310561), downloads that version's text release notes and prepends them to the changelog. Issues are filed on GitHub now, so a fix tracked by a GitHub issue never appears in the changelog. The script also exits with `Unable to retrieve the version ID from JIRA` when the release has no Jira version, which is what happens for a release made up only of GitHub issues. The changelog feeds more than the file itself. `release.sh` refuses to run without a changelog entry for the version, copies `CHANGELOG*` into the binary distribution and the dist.apache.org staging area, and puts the release's notes into `release-vote.txt` and `release-announce.txt`. It reads them from `/tmp/release-notes-$version.txt`, or failing that cuts the section out of the changelog by matching `Release Notes - Wicket - Version $version` up to the next `====` line. ## Expected - The release notes for a version combine the resolved Jira issues for that fix version with the GitHub issues resolved for the release. - A release without a Jira version still gets a changelog section from its GitHub issues alone, instead of failing. - The output keeps the current layout (`Release Notes - Wicket - Version X`, `** Bug` and similar groups, one `* [KEY] - summary` line per issue, `====` separators), so the extraction in `release.sh` and the existing changelog files keep working. GitHub issues need a key in that format, for example `[GH-1576]` or `[#1576]`. ## To decide The repository has no milestones and no labels for versions or issue types, so nothing on GitHub currently records which release an issue went into or whether it is a bug or an improvement. Options: - a milestone per release, set when an issue is fixed, and queried by the script; - the commits between the previous `rel/wicket-*` tag and the release, reading the `GitHub issue #N` references from the commit bodies and looking up each issue's title; - type labels (bug, improvement, …) to fill the `**` groups, or one group for all GitHub issues. The commit-based option needs no extra bookkeeping on issues, but only finds issues whose commits follow the convention of referencing them in the body. ## Branches The fix is needed on every line that still releases. `build-changelog.sh` is identical on `master`, `wicket-10.x` and `wicket-9.x`; on `wicket-8.x` it differs in how a version passed as argument is parsed (milestone suffix handling), so the change has to be adapted there. - [ ] `master` (11.x) - [ ] `wicket-10.x` - [ ] `wicket-9.x` - [ ] `wicket-8.x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
