dashorst opened a new issue, #1708: URL: https://github.com/apache/wicket/issues/1708
`release.sh` writes `release.properties` for `release:prepare` by appending the output of `./build-versions.py <release-version> <dev-version>`. That output gives every module of the reactor its release version and the next development version, so the Maven Release Plugin runs without asking for them module by module. The script does not work on any line that still releases: - It is Python 2 (`print` statements) behind `#!/usr/bin/python`. Where `python` is Python 3, as on current Fedora and Debian/Ubuntu, `release.sh` stops at that line with a `SyntaxError`. - Its module list is incomplete. It reads only the `<modules>` of the root `pom.xml` and of `wicket-native-websocket/pom.xml`, derives artifact IDs from directory names, and always adds `org.apache.wicket.experimental.wicket8:wicket-experimental`. The modules under `wicket-experimental` are missing, and `wicket-experimental` itself is emitted twice, under two wrong groupIds: | Branch | Emitted, but not a module | Missing | |---|---|---| | `master` | `org.apache.wicket:wicket-experimental`, `org.apache.wicket.experimental.wicket8:wicket-experimental` | `org.apache.wicket.experimental.wicket10`: `wicket-experimental`, `wicket-metrics` | | `wicket-10.x` | same as `master` | same as `master` | | `wicket-9.x` | same as `master` | `org.apache.wicket.experimental.wicket9`: `wicket-experimental`, `wicket-metrics`, `wicket-http2`, `wicket-http2-core`, `wicket-http2-jetty`, `wicket-http2-servlet4`, `wicket-http2-tomcat`, `wicket-http2-undertow` | | `wicket-8.x` | `org.apache.wicket:wicket-experimental` | `org.apache.wicket.experimental.wicket8`: `wicket-metrics`, `wicket-http2`, `wicket-http2-core`, `wicket-http2-jetty`, `wicket-http2-servlet4`, `wicket-http2-tomcat`, `wicket-http2-undertow` | For a module without an entry the release plugin falls back to prompting or to its own default, so it can end up with a different version than the rest of the release. ## Expected - The script runs on Python 3. - It emits exactly the modules of the reactor, with the groupId and artifactId each module's pom declares, by walking the `<modules>` tree from the root `pom.xml`. Adding or removing a module then needs no change to the script. The same script works unchanged on all four branches, since the module list comes from each branch's own poms. ## Branches - [ ] `master` (11.x) - [ ] `wicket-10.x` - [ ] `wicket-9.x` - [ ] `wicket-8.x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
