[
https://issues.apache.org/jira/browse/WINK-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716030#comment-13716030
]
Luciano Resende commented on WINK-388:
--------------------------------------
I noted that most of the tests from the project got removed with this patch. Is
that intentional ? Are we loosing test coverage here ?
# deleted:
wink-jcdi-server/src/test/java/org/apache/wink/jcdi/server/internal/extension/JAXRSJCDICustomInjectionTargetTest.java
# deleted:
wink-jcdi-server/src/test/java/org/apache/wink/jcdi/server/internal/extension/JAXRSJCDIExtensionTest.java
# deleted:
wink-jcdi-server/src/test/java/org/apache/wink/jcdi/server/internal/lifecycle/JCDIDefaultObjectFactoryTest.java
# deleted:
wink-jcdi-server/src/test/java/org/apache/wink/jcdi/server/internal/lifecycle/JCDILifecycleManagerTest.java
# deleted:
wink-jcdi-server/src/test/java/org/apache/wink/jcdi/server/internal/lifecycle/JCDISingletonObjectFactoryTest.java
> broken cdi integration
> ----------------------
>
> Key: WINK-388
> URL: https://issues.apache.org/jira/browse/WINK-388
> Project: Wink
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Gerhard Petracek
> Fix For: 1.4
>
> Attachments: WINK-388.patch
>
>
> list of issues:
> - JCDIDefaultObjectFactory doesn't use the cdi api correctly - e.g.:
> -- random behaviour in case of @Alternative and @Specializes beans
> -- managing instances manually is only valid for @Dependent scoped beans
> -- CreationalContext#release just destroys dependent scoped dependencies
> of the contextual-instance, but not the contextual-instance itself -> e.g.
> @PreDestroy callbacks don't get called for the contextual-instance itself
> - JCDISingletonObjectFactory isn't a valid approach
> -- JCDILifecycleManager only needs JCDIDefaultObjectFactory
> -- keeping dependent instances as "forced singletons" should be avoided
> -- during bootstrapping providers and instances of "application" need to
> be validated instead (of using JCDISingletonObjectFactory)
> - using mocks for cdi tests, won't show real issues
> -> arquillian or the test-module of OpenWebBeans should be used
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
