[ https://issues.apache.org/jira/browse/AXIOM-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088565#comment-13088565 ]
Hudson commented on AXIOM-377: ------------------------------ Integrated in ws-axiom-trunk #505 (See [https://builds.apache.org/job/ws-axiom-trunk/505/]) AXIOM-377: Don't pass the MIME parser to ContentStoreFactory, but only the input stream. AXIOM-377: Make sure that buildWithAttachments still behaves as expected, i.e. completely reads all referenced MIME parts. AXIOM-377 (step 3): Defer reading the MIME part content until it is requested from the DataHandler (previously the part was read when requesting the DataHandler). Avoid the call to Part#getSize() because this requires buffering of the part, which prevents us from implementing streaming (AXIOM-377) properly. The code was introduced by AXIOM-383 but is actually unnecessary: * The buffering logic works well with with empty attachments. * The case where "the stream end[s] without having a MIME message terminator" is irrelevant because such a message should generate an exception. veithen : Files : * /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/attachments/ContentStoreFactory.java * /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/attachments/PartImpl.java veithen : Files : * /webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMTextImpl.java * /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/SOAPTestSuiteBuilder.java * /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap12/envelope/TestBuildWithAttachments.java * /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/attachments/AttachmentsTest.java * /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/TestConstants.java * /webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/TextNodeImpl.java veithen : Files : * /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/attachments/MIMEMessage.java * /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/attachments/PartImpl.java veithen : Files : * /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/attachments/MIMEMessage.java > When a multipart message is built, there should be a way to retrieve a > DataHandler to the MTOM part without reading the entire incoming stream > ---------------------------------------------------------------------------------------------------------------------------------------------- > > Key: AXIOM-377 > URL: https://issues.apache.org/jira/browse/AXIOM-377 > Project: Axiom > Issue Type: New Feature > Reporter: Sadeep Jayasumana > Assignee: Andreas Veithen > Attachments: AXIOM-377.patch > > > This feature is particularly useful when large attachments are used. Building > large attachments in memory drives the system OOM and building them on files > dramatically reduces performance. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org