coheigea commented on a change in pull request #45:
URL: https://github.com/apache/ws-wss4j/pull/45#discussion_r817497144



##########
File path: parent/pom.xml
##########
@@ -56,10 +56,24 @@
         <wss4j.osgi.export>org.apache.wss4j.*</wss4j.osgi.export>
         <wss4j.osgi.dynamic.import />
         
<wss4j.manifest.location>${project.build.outputDirectory}/META-INF/MANIFEST.MF</wss4j.manifest.location>
+        <jakarta.xml.bind-api.version>3.0.1</jakarta.xml.bind-api.version>
+        <jakarta.mail.version>2.0.0</jakarta.mail.version>
+        <jaxb-runtime.version>3.0.2</jaxb-runtime.version>

Review comment:
       There are a bunch of old JAXB dependencies in the root pom under the 
JDK9 profile that need to be removed:
   
   <dependency>
                        <groupId>jakarta.xml.ws</groupId>
                        <artifactId>jakarta.xml.ws-api</artifactId>
                        <version>2.3.3</version>
                    </dependency>
                    <dependency>
                        <groupId>jakarta.xml.bind</groupId>
                        <artifactId>jakarta.xml.bind-api</artifactId>
                        <version>2.3.3</version>
                    </dependency>
                    <dependency>
                        <groupId>org.glassfish.jaxb</groupId>
                        <artifactId>jaxb-runtime</artifactId>
                        <version>2.3.2</version>
                        <scope>test</scope>
                    </dependency>
   Once these are removed, then you can remove the jakarta API from 
ws-security-stax etc., as it is added already as a compile time dependency in 
Santuario (I changed it this morning so you might need to reinstall it).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org
For additional commands, e-mail: dev-h...@ws.apache.org

Reply via email to