coheigea commented on PR #741: URL: https://github.com/apache/ws-wss4j/pull/741#issuecomment-6035376463
Can you address these comments please: Unused imports in 5 test files. import static org.junit.jupiter.api.Assumptions.assumeFalse; is still there, but every use was removed: NameConstraintsTest.java dom AttachmentTest.java EncryptionGCMTest.java stax AttachmentTest.java EncDecryptionTest.java CI didn't catch these because checkstyle and PMD run with includeTests=false. They should still be removed. Dead code in KerberosTest. With the IBM check gone, runTests is only ever true. The field and its 9 if (!runTests) return; checks do nothing now. Either remove them, or skip only when the KDC fails to start. Blank first lines in methods. In NameConstraintsTest (about 9 methods), the assumeFalse(isIBMJdK); line was deleted but the blank line after it was kept, so each method body now starts with an empty line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
