coheigea opened a new pull request, #775: URL: https://github.com/apache/ws-wss4j/pull/775
The Timestamp replay cache identifier was a digest over the Created value and the SignatureValue (plus the signing key in DOM). The SignatureValue is not covered by the signature, and for ECDSA and DSA a second valid value can be computed from a captured one without the key: (r, s) becomes (r, n - s). A replayed message rewritten that way got a new identifier, missed the cache and was accepted again. Use the URI and DigestValue of each Reference of the SignedInfo instead, which cannot be changed without breaking the signature. The new DOM test rewrites the SignatureValue of an ECDSA-signed message, checks that it still verifies, and checks that it is rejected as a replay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
