On Sun, Mar 11, 2012 at 1:13 PM, Nirmal Fernando <[email protected]> wrote:

>
>
> On Sun, Mar 11, 2012 at 1:09 PM, Amila Jayasekara <[email protected]> wrote:
>
>>
>>
>> On Sun, Mar 11, 2012 at 11:17 AM, Selvaratnam Uthaiyashankar <
>> [email protected]> wrote:
>>
>>>
>>>
>>> On Sun, Mar 11, 2012 at 10:54 AM, Amila Jayasekara <[email protected]>wrote:
>>>
>>>> Due to some reason "serverAdmin.restart()" only halts JVM but does not
>>>> restart the server. This only happens when executing test case. But through
>>>> UI server restarts fine. Further investigating the cause.
>>>>
>>>
>>> restart happnes through wso2server.sh. When restarting, it returns error
>>> code 121 and wso2server.sh checks that and restart JVM. I guess, the
>>> integration test's server startup in linux is having an issue, where when
>>> JVM stops the shell is also exiting, so that restart is not happening.
>>>
>>
>> Guess we found the cause for the issue.
>> When "test" parameter is passed wso2server.sh, it does following,
>>
>> elif [ "$CMD" = "test" ]; then
>>     JAVACMD="exec "$JAVACMD""
>>
>> Above causes shell process image to be replaced with Java process.
>> Therefore during a restart, once process goes down the whole command is
>> terminated. We can fix restart tests by removing above exec logic.
>>
>
> Out of curiosity, how did this test pass earlier?
>


I introduced "sleep" between "restart" process and "waitforport"  call.
Until now, the test passed, but what the test "testing" was wrong. Find
more details in [1].

Regards,
Shankar

[1] https://wso2.org/jira/browse/CARBON-12546


>
>
>> But first need to verify the reason for including "exec" command ?
>>
>> In addition from Shankar verified that "test" parameter logic is not
>> there in wso2server.bat. Therefore tests are passing in Windows.
>>
>> I will commit changes once trunk is unfrozen.
>>
>> Thanks
>> AmilaJ
>>
>>
>>
>>
>>
>>
>>>
>>>
>>>>
>>>> Thanks
>>>> AmilaJ
>>>>
>>>>
>>>> On Sun, Mar 11, 2012 at 9:58 AM, Selvaratnam Uthaiyashankar <
>>>> [email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Sun, Mar 11, 2012 at 9:37 AM, Afkham Azeez <[email protected]> wrote:
>>>>>
>>>>>> Perhaps restart is broken?
>>>>>
>>>>>
>>>>>
>>>>> It works fine in my machine (Windows). AmilaJ is now doing a full
>>>>> build on Linux to see whether restart broken in Linux.
>>>>>
>>>>>
>>>>>> Or the test timeout is too low.
>>>>>
>>>>>
>>>>> In my machine, restart finish in 10 sec. We have given 5 minutes as
>>>>> the timeout in the test case. Do you think restart or carbon kernel might
>>>>> take more than 5 minutes?
>>>>>
>>>>> Regards,
>>>>> Shankar
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Mar 11, 2012 at 8:53 AM, Selvaratnam Uthaiyashankar <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> I increased the waitforport timout to 5 minutes, but still these
>>>>>>> tests are failing. That means, the restart process didn't finish within 
>>>>>>> 5
>>>>>>> minutes in builder machine. Anybody knows the reason?
>>>>>>>
>>>>>>> Shankar
>>>>>>>
>>>>>>> On Sat, Mar 10, 2012 at 9:45 PM, Bamboo <[email protected]> wrote:
>>>>>>>
>>>>>>>>      [image: Failed]  
>>>>>>>> Carbon-Kernel<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL/>›
>>>>>>>> Carbon-Kernel<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD/>›
>>>>>>>> #69<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-69/>
>>>>>>>> failed
>>>>>>>>
>>>>>>>> Code has been updated by 
>>>>>>>> shankar<http://builder4.us1.wso2.org:8888/bamboo/browse/author/shankar>
>>>>>>>> .
>>>>>>>>
>>>>>>>> *2/2786* tests failed.
>>>>>>>>    Failing 
>>>>>>>> Jobs<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-69/>
>>>>>>>>     Job
>>>>>>>> Duration Tests    [image: Failed]  Default 
>>>>>>>> Job<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-JOB1-69/>
>>>>>>>>  (Default
>>>>>>>> Stage)  76 minutes  2 of 2786 failed  
>>>>>>>> Logs<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-JOB1-69/log>|
>>>>>>>> Artifacts<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-JOB1-69/artifact>
>>>>>>>>      Code
>>>>>>>> Changes<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-69/commit/>
>>>>>>>>   View
>>>>>>>> full change 
>>>>>>>> details<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-69/commit/>
>>>>>>>> shankar<http://builder4.us1.wso2.org:8888/bamboo/browse/author/shankar>
>>>>>>>> increasing timeout for "waitForPort", because restart process might
>>>>>>>> take more than default timeout.  122316     
>>>>>>>> Tests<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-69/test>
>>>>>>>>   View
>>>>>>>> full test 
>>>>>>>> details<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-69/test>
>>>>>>>>    2
>>>>>>>> Existing Test Failures   Test Job     ServerRestartTestCase
>>>>>>>> testGracefulServerRestart<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-JOB1-69/test/case/7637724>
>>>>>>>>   Default
>>>>>>>> Job<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-JOB1-69/test>
>>>>>>>> ServerRestartTestCase 
>>>>>>>> testServerRestart<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-JOB1-69/test/case/7637727>
>>>>>>>>   Default
>>>>>>>> Job<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-JOB1-69/test>
>>>>>>>>      View
>>>>>>>> Online<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-69>
>>>>>>>> | Add 
>>>>>>>> Comments<http://builder4.us1.wso2.org:8888/bamboo/browse/WSO2CARBONKERNEL-CARBONCOREKERNELBUILD-69?commentMode=true>
>>>>>>>>
>>>>>>>> This message was sent by Atlassian 
>>>>>>>> Bamboo<http://builder4.us1.wso2.org:8888/bamboo>
>>>>>>>> .
>>>>>>>>
>>>>>>>> If you wish to stop receiving these emails edit your user 
>>>>>>>> profile<http://builder4.us1.wso2.org:8888/bamboo/profile/userNotifications.action>or
>>>>>>>>  notify
>>>>>>>> your 
>>>>>>>> administrator<http://builder4.us1.wso2.org:8888/bamboo/viewAdministrators.action>
>>>>>>>> .
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> Dev mailing list
>>>>>>>> [email protected]
>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> S.Uthaiyashankar
>>>>>>> Senior Architect
>>>>>>> WSO2 Inc.
>>>>>>> http://wso2.com/ - "lean . enterprise . middleware"
>>>>>>>
>>>>>>> Phone: +94 714897591
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Dev mailing list
>>>>>>> [email protected]
>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Afkham Azeez*
>>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com
>>>>>> Member; Apache Software Foundation; http://www.apache.org/
>>>>>> * <http://www.apache.org/>**
>>>>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>>>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>>>>>> twitter: 
>>>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>>>>>> *
>>>>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>>>>>> *
>>>>>> *
>>>>>> *Lean . Enterprise . Middleware*
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> S.Uthaiyashankar
>>>>> Senior Architect
>>>>> WSO2 Inc.
>>>>> http://wso2.com/ - "lean . enterprise . middleware"
>>>>>
>>>>> Phone: +94 714897591
>>>>>
>>>>> _______________________________________________
>>>>> Dev mailing list
>>>>> [email protected]
>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Mobile : +94773330538
>>>>
>>>
>>>
>>>
>>> --
>>> S.Uthaiyashankar
>>> Senior Architect
>>> WSO2 Inc.
>>> http://wso2.com/ - "lean . enterprise . middleware"
>>>
>>> Phone: +94 714897591
>>>
>>
>>
>>
>> --
>> Mobile : +94773330538
>>
>> _______________________________________________
>> Dev mailing list
>> [email protected]
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
>
> Thanks & regards,
> Nirmal
>
> Software Engineer- Platform Technologies Team, WSO2 Inc.
> Mobile: +94715779733
> Blog: http://nirmalfdo.blogspot.com/
>



-- 
S.Uthaiyashankar
Senior Architect
WSO2 Inc.
http://wso2.com/ - "lean . enterprise . middleware"

Phone: +94 714897591
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to