Yes, I am fixing for the other places. :)

Regards,
Pradeeban.

On Wed, Mar 28, 2012 at 10:32 AM, Supun Malinga <[email protected]> wrote:

>
>
> On Wed, Mar 28, 2012 at 9:30 AM, Afkham Azeez <[email protected]> wrote:
>
>> This is a problem. The issue here is, when we do mvn deploy:deploy, the
>> pom will get deployed to the Maven repo with this *${orbit.version.jgroups}
>> *not the real version. That is why Maven is giving this warning.
>>
>> It is perfectly alright to use these properties such as 
>> *${orbit.version.jgroups}
>> *while declaring dependencies, but it is wrong to use them when
>> declaring version of the artifacts & POMs. So, this definitely has to be
>> fixed. This would have been added in error. This is no de-facto Carbon
>> convention when it comes to declaring versions of artifacts. This is a
>> mistake by whoever who added this POM. Please fix it.
>>
>
> yes,
> +1 for searching these places and fixing :)
>
>>
>> Thanks
>> Azeez
>>
>> On Wed, Mar 28, 2012 at 8:28 AM, Kathiravelu Pradeeban <
>> [email protected]> wrote:
>>
>>> Hi,
>>> I have completed fixing the remaining maven3 warnings that are shown
>>> during the start of the build, except the warning below. Will commit the
>>> changes after building from the top-level.
>>>
>>> [WARNING]
>>> [WARNING] Some problems were encountered while building the effective
>>> model for org.jgroups.wso2:jgroups:bundle:3.0.6.wso2v1
>>> [WARNING] 'version' contains an expression but should be a constant. @
>>> org.jgroups.wso2:jgroups:${orbit.version.jgroups},
>>> /home/pradeeban/carbon/orbit/jgroups/pom.xml, line 34, column 14
>>> [WARNING]
>>>
>>> This is because of the use of the *expressions* instead of a constant
>>> for the *version* in the pom.xml, as below.
>>>     <modelVersion>4.0.0</modelVersion>
>>>     <groupId>org.jgroups.wso2</groupId>
>>>     <artifactId>jgroups</artifactId>
>>>     <packaging>bundle</packaging>
>>>     <name>jgroups.wso2</name>
>>> *    <version>${orbit.version.jgroups}</version>
>>> *    <description>
>>>         This bundle will export packages from jgroups
>>>     </description>
>>>     <url>http://wso2.org</url>
>>>
>>>
>>> Regardless of the maven3 warning, we are using the above way of giving
>>> the version, probably as a de facto convention of Carbon.
>>> Hence I am not modifying them, ignoring those warnings.
>>>
>>> Do let me know, if there is any better approach for this.
>>>
>>> Thank you.
>>> Regards,
>>> Pradeeban.
>>>
>>> --
>>> Kathiravelu Pradeeban.
>>> Software Engineer.
>>> Cloud Technologies Team.
>>> WSO2 Inc.
>>>
>>> Blog: [Llovizna] http://kkpradeeban.blogspot.com/
>>> M: +94 776 477 976
>>>
>>>
>>> _______________________________________________
>>> Dev mailing list
>>> [email protected]
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> *Afkham Azeez*
>> Director of Architecture; WSO2, Inc.; http://wso2.com
>> Member; Apache Software Foundation; http://www.apache.org/
>> * <http://www.apache.org/>**
>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>> *
>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>> *
>> *
>> *Lean . Enterprise . Middleware*
>>
>>
>> _______________________________________________
>> Dev mailing list
>> [email protected]
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Supun Malinga,
>
> Software Engineer,
> WSO2 Inc.
> http://wso2.com
> http://wso2.org
> email - [email protected] <[email protected]>
> mobile - 071 56 91 321
>
>


-- 
Kathiravelu Pradeeban.
Software Engineer.
Cloud Technologies Team.
WSO2 Inc.

Blog: [Llovizna] http://kkpradeeban.blogspot.com/
M: +94 776 477 976
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to