Hi Senaka, On Tue, May 8, 2012 at 4:01 PM, Senaka Fernando <sen...@wso2.com> wrote:
> Hi all, > > Hold on. AFAIU, Ajith says the DeleteServiceHandler is required for > something else. We better figure that out and make sure that is properly > fixed. Because from what I understand that handler is needed though it > created a regression, and the fix for that regression, Janaka is not to > simply comment that out and keep shut :(. > My Bad. I thought I had reopened the other JIRA and it seems like I haven't done so. Sorry about that. Thanks, Janaka > > Vijitha, the rest of the handler are good to go if they are not used. > > Thanks, > Senaka. > > > On Tue, May 8, 2012 at 10:11 PM, Vijitha Kumara <viji...@wso2.com> wrote: > >> I think there's no point in keeping the source/config files related to >> those handlers and eventually shipped the jars which are not used. So we >> should clean them up too... >> >> >> On Tue, May 8, 2012 at 9:18 PM, Janaka Ranabahu <jan...@wso2.com> wrote: >> >>> Hi, >>> >>> On Tue, May 8, 2012 at 4:42 AM, Senaka Fernando <sen...@wso2.com> wrote: >>> >>>> Yes. >>>> >>>> Thanks, >>>> Senaka. >>>> >>>> >>>> On Tue, May 8, 2012 at 5:07 PM, Vijitha Kumara <viji...@wso2.com>wrote: >>>> >>>>> Also, ProcessMediaTypeHandler & SLAMediaTypeHandler can be removed? >>>>> >>>>> >>>>> On Tue, May 8, 2012 at 4:12 PM, Senaka Fernando <sen...@wso2.com>wrote: >>>>> >>>>>> Hi Ajith, >>>>>> >>>>>> Janaka apparently commented it out in r114979. >>>>>> >>>>> >>> Thats because this handler was causing some other issue. Please refer >>> [1]. If we are going to add this, then we need to fix these issues as well. >>> IIRC, I discussed this with Ajith before I commented out the handler. >>> >>> Thanks, >>> Janaka >>> >>> [1] https://wso2.org/jira/browse/CARBON-11332 >>> >>>> >>>>>> Thanks, >>>>>> Senaka. >>>>>> >>>>>> On Tue, May 8, 2012 at 4:11 PM, Ajith Vitharana <aji...@wso2.com>wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Tue, May 8, 2012 at 3:59 PM, Senaka Fernando <sen...@wso2.com>wrote: >>>>>>> >>>>>>>> Hi Vijitha, >>>>>>>> >>>>>>>> Yes please. I thought we did it sometime in the past. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Senaka. >>>>>>>> >>>>>>>> >>>>>>>> On Tue, May 8, 2012 at 3:53 PM, Vijitha Kumara <viji...@wso2.com>wrote: >>>>>>>> >>>>>>>>> Hi All, >>>>>>>>> >>>>>>>>> While adding some comments to describe the G-Regs config >>>>>>>>> (registry.xml), I learned that some handlers are not used within the >>>>>>>>> registry (i.e.: PeopleMediaTypeHandler). They still available in the >>>>>>>>> registry.xml. Should we remove this altogether? >>>>>>>>> >>>>>>>> >>>>>>> Hi Senaka, >>>>>>> >>>>>>> We have included "DeleteServiceHandler" to remove collection >>>>>>> hierarchy when delete a service. >>>>>>> But that handler has commented in the default pack? >>>>>>> >>>>>>> <!--handler >>>>>>> class="org.wso2.carbon.registry.extensions.handlers.DeleteServiceHandler"> >>>>>>> <filter >>>>>>> class="org.wso2.carbon.registry.core.jdbc.handlers.filters.MediaTypeMatcher"> >>>>>>> <property >>>>>>> name="mediaType">application/vnd.wso2-service+xml</property> >>>>>>> </filter> >>>>>>> </handler--> >>>>>>> >>>>>>> >>>>>>> Thanks >>>>>>> Ajith >>>>>>> >>>>>>> >>>>>>>>> -- >>>>>>>>> Vijitha Kumara >>>>>>>>> Senior Software Engineer; WSO2, Inc.; http://wso2.com/ >>>>>>>>> email: viji...@wso2.com >>>>>>>>> >>>>>>>>> Lean . Enterprise . Middleware >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Senaka Fernando* >>>>>>>> Product Manager - WSO2 Governance Registry; >>>>>>>> Associate Technical Lead; WSO2 Inc.; http://wso2.com* >>>>>>>> Member; Apache Software Foundation; http://apache.org >>>>>>>> >>>>>>>> E-mail: senaka AT wso2.com >>>>>>>> **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 >>>>>>>> Linked-In: http://linkedin.com/in/senakafernando >>>>>>>> >>>>>>>> * >>>>>>>> Lean . Enterprise . Middleware >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Ajith Vitharana. >>>>>>> WSO2 Inc. - http://wso2.org >>>>>>> Email : aji...@wso2.com >>>>>>> Mobile : +94714631794 >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Senaka Fernando* >>>>>> Product Manager - WSO2 Governance Registry; >>>>>> Associate Technical Lead; WSO2 Inc.; http://wso2.com* >>>>>> Member; Apache Software Foundation; http://apache.org >>>>>> >>>>>> E-mail: senaka AT wso2.com >>>>>> **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 >>>>>> Linked-In: http://linkedin.com/in/senakafernando >>>>>> >>>>>> *Lean . Enterprise . Middleware >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Vijitha Kumara >>>>> Senior Software Engineer; WSO2, Inc.; http://wso2.com/ >>>>> email: viji...@wso2.com >>>>> >>>>> Lean . Enterprise . Middleware >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Senaka Fernando* >>>> Product Manager - WSO2 Governance Registry; >>>> Associate Technical Lead; WSO2 Inc.; http://wso2.com* >>>> Member; Apache Software Foundation; http://apache.org >>>> >>>> E-mail: senaka AT wso2.com >>>> **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 >>>> Linked-In: http://linkedin.com/in/senakafernando >>>> >>>> *Lean . Enterprise . Middleware >>>> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Janaka Ranabahu >>> Software Engineer >>> WSO2 Inc. >>> >>> Mobile +94 718370861 >>> Email : jan...@wso2.com >>> Blog : janakaranabahu.blogspot.com >>> >>> >> >> >> -- >> Vijitha Kumara >> Senior Software Engineer; WSO2, Inc.; http://wso2.com/ >> email: viji...@wso2.com >> >> Lean . Enterprise . Middleware >> >> > > > -- > *Senaka Fernando* > Product Manager - WSO2 Governance Registry; > Associate Technical Lead; WSO2 Inc.; http://wso2.com* > Member; Apache Software Foundation; http://apache.org > > E-mail: senaka AT wso2.com > **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 > Linked-In: http://linkedin.com/in/senakafernando > > *Lean . Enterprise . Middleware > > > _______________________________________________ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Janaka Ranabahu Software Engineer WSO2 Inc. Mobile +94 718370861 Email : jan...@wso2.com Blog : janakaranabahu.blogspot.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
