On Fri, May 11, 2012 at 6:35 AM, Srinath Perera <srin...@wso2.com> wrote:
> Please see comments inline. I think this is good, apart from few minor > things I mentioned. > > > On Thu, May 10, 2012 at 4:50 PM, Charith Wickramarachchi > <char...@wso2.com> wrote: > > Hi Srinath , > > > > Please find the svn urls for the important classes with small detail on > the > > usage > > > > org.wso2.andes.server.subscription.SubscriptionImpl.AckSubscription > > ( > https://svn.wso2.org/repos/wso2/carbon/platform/trunk/dependencies/andes/java/broker/src/main/java/org/wso2/andes/server/subscription/SubscriptionImpl.java > ) > > > > In the send method of this we send the messages > > At "System.out.println("false");" here put a debug message with more > detials > > Sorry about the sys out. i thought i removed all the sysouts before committing. > > > > org.wso2.andes.server.output.amqp0_9_1.ProtocolOutputConverterImpl > > ( > https://svn.wso2.org/repos/wso2/carbon/platform/trunk/dependencies/andes/java/broker/src/main/java/org/wso2/andes/server/output/amqp0_9_1/ProtocolOutputConverterImpl.java > ) > > writeMessageDelivery in this (Line number 104 ) got that while loop > which > > ended up in a infinite loop > > > > > > org.wso2.andes.server.cassandra.QueueSubscriptionAcknowledgementHandler > > ( > https://svn.wso2.org/repos/wso2/carbon/platform/trunk/dependencies/andes/java/broker/src/main/java/org/wso2/andes/server/cassandra/QueueSubscriptionAcknowledgementHandler.java > ) > > Is the onc which handle the acks It also have a inner class which does > the > > clean up. > > In if(timeStampAckedMessageIdMap.firstKey() + ackedMessageTimeOut < > currentTime) {, lets make ackedMessageTimeOut 2X ackedMessageTimeOut > to be safe. > > In checkAndRegisterSent(), we should be able to move "if (cleanupJob > == null) {" block to a constructor > > > > Thanks for the feedback. Will do the suggested changes. regards, Charith > > > > org.wso2.andes.server.AMQChanne > > ( > https://svn.wso2.org/repos/wso2/carbon/platform/trunk/dependencies/andes/java/broker/src/main/java/org/wso2/andes/server/AMQChannel.java > ) > > > > Method acknowledgeMessage handle the ack > > > > thanks, > > Charith > > > > > > > > -- > > Charith Dhanushka Wickramarachchi > > Software Engineer > > WSO2 Inc > > http://wso2.com/ > > http://wso2.org/ > > > > blog > > http://charithwiki.blogspot.com/ > > > > twitter > > http://twitter.com/charithwiki > > > > Mobile : 0776706568 > > > > > > > > -- > ============================ > Srinath Perera, Ph.D. > Senior Software Architect, WSO2 Inc. > Visiting Faculty, University of Moratuwa > Member, Apache Software Foundation > Research Scientist, Lanka Software Foundation > Blog: http://srinathsview.blogspot.com/ > Photos: http://www.flickr.com/photos/hemapani/ > Phone: 0772360902 > -- Charith Dhanushka Wickramarachchi Software Engineer WSO2 Inc http://wso2.com/ http://wso2.org/ blog http://charithwiki.blogspot.com/ twitter http://twitter.com/charithwiki Mobile : 0776706568
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
