Hi Amila,

On Thu, Jul 26, 2012 at 2:54 PM, Amila Maha Arachchi <ami...@wso2.com>wrote:

>
>
> On Thu, Jul 26, 2012 at 2:45 PM, Dimuthu Leelarathne <dimut...@wso2.com>wrote:
>
>>
>>
>> On Thu, Jul 26, 2012 at 1:22 PM, Kasun Gajasinghe <kas...@wso2.com>wrote:
>>
>>>
>>> As I've seen,
>>>
>>> 1. Changing org.wso2.carbon.appfactory.events.notification/1.0.0
>>> to org.wso2.carbon.appfactory.events.notification in appfactory/pom.xml
>>> 2. Changing the version of pom.xml
>>> of appfactory/org.wso2.carbon.appfactory.events.notification/pom.xml from
>>> 1.0.0-SNAPSHOT to 1.0.0
>>> 3. Correcting the version of the dependency
>>> org.wso2.carbon.appfactory.application.mgt to 1.0.0
>>>
>>> makes it work. I'm not sure whether this is the right approach though.
>>>
>>
>> +1
>>
>
> I dont think this is correct. Every stub/component/feature/product should
> have a versioned folder inside them. Otherwise how are you going to do a
> patch/minor release for the above. For example after releasing AF 1.0.0,
> you decide to release AF 1.0.1. You need to branch the AF
> components/features/stubs for this (if there are changes in them). Then you
> cannot do it with this folder structure.
>

Just checked. You are correct our events bundle doesn't have a versioned
folder (other appfactory components do have such a version  numbered
folder) and I think it is a miss on our side. For now lets have KasunG's
commit to enable the rest of the team to continue. We'll fix this ASAP.

thanks,
dimuthu




>
>> thanks,
>> dimuthu
>>
>>
>>>
>>> Thanks,
>>> --KasunG
>>>
>>>
>>> On Thu, Jul 26, 2012 at 1:11 PM, Kasun Gajasinghe <kas...@wso2.com>wrote:
>>>
>>>> Hi,
>>>> Seems the maven project structure for
>>>> appfactory's org.wso2.carbon.appfactory.events.notification module. There
>>>> isn't a appfactory/org.wso2.carbon.appfactory.events.notification/1.0.0
>>>> directory there. You'll face issues when building with a clean repo. Please
>>>> fix.
>>>>
>>>>
>>>> kasun@kasunbg-laptop:~/wso2/C4-dist-branch/platform/components/appfactory$
>>>> mvnc4 install -Dmaven.test.skip=true
>>>> [INFO] Scanning for projects...
>>>> [ERROR] The build could not read 1 project -> [Help 1]
>>>> [ERROR]
>>>> [ERROR]   The project org.wso2.carbon:appfactory:1.0.0
>>>> (/home/kasun/wso2/C4-dist-branch/platform/components/appfactory/pom.xml)
>>>> has 1 error
>>>> [ERROR]     Child module
>>>> /home/kasun/wso2/C4-dist-branch/platform/components/appfactory/org.wso2.carbon.appfactory.events.notification/1.0.0
>>>> of /home/kasun/wso2/C4-dist-branch/platform/components/appfactory/pom.xml
>>>> does not exist
>>>> [ERROR]
>>>> [ERROR] To see the full stack trace of the errors, re-run Maven with
>>>> the -e switch.
>>>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>>>> [ERROR]
>>>> [ERROR] For more information about the errors and possible solutions,
>>>> please read the following articles:
>>>> [ERROR] [Help 1]
>>>> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
>>>>
>>>>
>>>> Thanks,
>>>> --KasunG
>>>>
>>>> --
>>>> *Kasun Gajasinghe*
>>>> Software Engineer;
>>>> Development Technologies Team, WSO2 Inc.; http://wso2.com ,
>>>> *email: **kasung AT spamfree wso2.com** cell: **+94 (77) 678-0813*
>>>> *linked-in: *http://lk.linkedin.com/in/gajasinghe*
>>>> *
>>>>  *blog: **http://blog.kasunbg.org* <http://blog.kasunbg.org>*
>>>> twitter: **http://twitter.com/kasunbg* <http://twitter.com/kasunbg>*
>>>> *
>>>>
>>>>
>>>
>>>
>>> --
>>> *Kasun Gajasinghe*
>>> Software Engineer;
>>> Development Technologies Team, WSO2 Inc.; http://wso2.com ,
>>> *email: **kasung AT spamfree wso2.com** cell: **+94 (77) 678-0813*
>>> *linked-in: *http://lk.linkedin.com/in/gajasinghe*
>>> *
>>>  *blog: **http://blog.kasunbg.org* <http://blog.kasunbg.org>*
>>> twitter: **http://twitter.com/kasunbg* <http://twitter.com/kasunbg>*
>>> *
>>>
>>>
>>
>> _______________________________________________
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> *Amila Maharachchi*
> Technical Lead
> Member, Management Committee - Cloud & Platform TG
> WSO2, Inc.; http://wso2.com
>
> Blog: http://maharachchi.blogspot.com
> Mobile: +94719371446
>
>
>
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to