Hi all, Below are the facts that I could capture during the review.
- Remove versions attribute from Application.java since it will not be used. - As future enhancements, there is a possibility of adding more attributes to Version.java (eg: who created the version, date of version creation etc. - This will be useful for the graphical representation of the versions ) - Remove the method removeRolesUserAlreadyIn() in ApplicationManagementService.java - Add validation to check if a user is an Admin user before adding to application. - In future, we may need to add any pre-listeners, post-listeners to be implemented if required. They can be added to the ApplicationManager.java - Rename Util.java class in org.wso2.carbon.appfactory.application.mgt bundle to a name like xxxService. Put that class to an internal directory. - Remove the authenticate attribute in JenkinsBuildServiceComponent - When creating the jenkinsURL, the appending string with "com.michelin.cio.hudson.plugins.rolestrategy.RoleBasedAuthorizationStrategy" should be defined as a Constant and use. - Add specific error messages rather than the generic errors as much as possible when you know what causes the error. Others, please add or modify the things I have missed. Thanks Manisha On Fri, Oct 12, 2012 at 10:23 AM, Ramith Jayasinghe <[email protected]> wrote: > more details > »<https://www.google.com/calendar/event?action=VIEW&eid=MzduZnRibmx2djM2bWxtazdpOWJiOGlzZWcgbWFuaXNoYUB3c28yLmNvbQ&tok=MTUjcmFtaXRoQHdzbzIuY29tMmQ0ZjFlN2M5YzRlY2Y0YTViZmNhYjlhODExYmU1N2M1NTRjYTI5ZQ&ctz=Asia/Colombo&hl=en> > Code Review - Jenkins > Code review for Appfactory Jenkins CI Driver. > *When* > Tue Oct 16 2pm – 3pm Colombo > *Where* > LK #58 5th Floor - Meeting room > (map<http://maps.google.lk/maps?q=LK+%2358+5th+Floor+-+Meeting+room&hl=en> > ) > *Calendar* > [email protected] > *Who* > • > Ramith Jayasinghe - organizer > • > Selvaratnam Uthaiyashankar > • > Thilini Ishaka > • > Achala Aponso > • > Ajanthan Balachandran > • > Manisha Gayathri > • > Manjula Rathnayake > • > Tharindu Dassanayake > • > Dilshan Edirisuriya > • > [email protected] > • > Ashansa Perera > • > Dimuthu Leelarathne > • > Janaka Ranabahu > > Going? > ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=MzduZnRibmx2djM2bWxtazdpOWJiOGlzZWcgbWFuaXNoYUB3c28yLmNvbQ&rst=1&tok=MTUjcmFtaXRoQHdzbzIuY29tMmQ0ZjFlN2M5YzRlY2Y0YTViZmNhYjlhODExYmU1N2M1NTRjYTI5ZQ&ctz=Asia/Colombo&hl=en>- > Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=MzduZnRibmx2djM2bWxtazdpOWJiOGlzZWcgbWFuaXNoYUB3c28yLmNvbQ&rst=3&tok=MTUjcmFtaXRoQHdzbzIuY29tMmQ0ZjFlN2M5YzRlY2Y0YTViZmNhYjlhODExYmU1N2M1NTRjYTI5ZQ&ctz=Asia/Colombo&hl=en>- > No<https://www.google.com/calendar/event?action=RESPOND&eid=MzduZnRibmx2djM2bWxtazdpOWJiOGlzZWcgbWFuaXNoYUB3c28yLmNvbQ&rst=2&tok=MTUjcmFtaXRoQHdzbzIuY29tMmQ0ZjFlN2M5YzRlY2Y0YTViZmNhYjlhODExYmU1N2M1NTRjYTI5ZQ&ctz=Asia/Colombo&hl=en> > * **more options > »<https://www.google.com/calendar/event?action=VIEW&eid=MzduZnRibmx2djM2bWxtazdpOWJiOGlzZWcgbWFuaXNoYUB3c28yLmNvbQ&tok=MTUjcmFtaXRoQHdzbzIuY29tMmQ0ZjFlN2M5YzRlY2Y0YTViZmNhYjlhODExYmU1N2M1NTRjYTI5ZQ&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for invitations on calendar [email protected]. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- ~Regards *Manisha Eleperuma* Software Engineer WSO2, Inc.: http://wso2.com lean.enterprise.middleware *mobile: +94 71 8279777* * *
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
