On Sat, Oct 27, 2012 at 6:39 AM, Afkham Azeez <az...@wso2.com> wrote:

> On Sat, Oct 27, 2012 at 6:25 AM, Selvaratnam Uthaiyashankar <
> shan...@wso2.com> wrote:
>
>> Hi,
>>
>> Check the following API (in 3.2.2 branch.. haven't checked in 4.0.0
>> branch)
>> SecretResolver
>> org.wso2.securevault.SecretResolverFactory.create(OMElement configuration,
>> boolean isCapLetter)
>>
>>
>> why do we need the parameter "isCapLetter"? If it is true, it is
>> searching for an element "SecureVault" and if false, it is searching for
>> "secureVault" element. However, this is not a userlevel parameter. This API
>> does not look good :).
>>
>>
> !!! yes, that is an implementation detail, and should never be part os the
> API!
>

Not only that .. this is stuff that should not be configurable.

Sanjiva.
-- 
Sanjiva Weerawarana, Ph.D.
Founder, Chairman & CEO; WSO2, Inc.;  http://wso2.com/
email: sanj...@wso2.com; phone: +94 11 763 9614; cell: +94 77 787 6880 | +1
650 265 8311
blog: http://sanjiva.weerawarana.org/

Lean . Enterprise . Middleware
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to