On Thu, Jul 11, 2013 at 10:21 AM, Prabath Siriwardena <[email protected]>wrote:

> UserStoreManager API is not clean at all.. There so many stuff can
> remove... Also maintain two interfaces one in the core and another in API.
> We need to get rid of the interface in core..
>
> On Thu, Jul 11, 2013 at 10:06 AM, Asela Pathberiya <[email protected]> wrote:
>
>> Hi All,
>>
>> I am not sure why we are keeping following method in the API... Sorry, if
>> i have missed any thing....  If there are on any usage, we can remove
>> them...
>>
>> 1. String[] getAllSecondaryRoles()
>>
>> Why we need only the roles of secondary user store?
>>
>
> This is useful.. In a multi-tenanted environment - primary user store is
> governed by the super tenant.. It's also better to have a method
> getRoles(String userStoreDomain).
>

This is wrong. You should not try to get the roles from the UserStore.
Roles has to come from the Authorization manager.

thanks,
Amila.

>
> Thanks & regards,
> -Prabath
>
>
>>
>> 2.  int getTenantId(String username)
>>
>> Once user is authenticated, we knows the tenant Id.  Else why we need to
>> get the tenant id of a user who is not in its tenant space ?
>>
>> 3. int getUserId(String username)
>>
>> What is the use of user id?  It seems to this is auto increment value of
>> UM_USER table
>>
>> 4.  int getTenantId()
>>
>> I guess,  tenant Id is not need to expose via user store manager API, it
>> is available with carbon context
>>
>> Thanks,
>> Asela.
>>
>> --
>> Thanks & Regards,
>> Asela
>>
>> Mobile : +94 777 625 933
>>
>
>
>
> --
> Thanks & Regards,
> Prabath
>
> Mobile : +94 71 809 6732
>
> http://blog.facilelogin.com
> http://RampartFAQ.com
>
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Amila Suriarachchi*

Software Architect
WSO2 Inc. ; http://wso2.com
lean . enterprise . middleware

phone : +94 71 3082805
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to