Hi All,

There was a bug in updateUsersOfRole() in UserRealmProxy.java [1] and Asela
fixed that. While debugging this code I found that lot of improvements
should be done in this space. And also huge performance issues as well,

Eg: call getUserListOfRole (roleName); several times in same method.

[1]
https://svn.wso2.org/repos/wso2/carbon/platform/trunk/components/user-manager/org.wso2.carbon.user.mgt/src/main/java/org/wso2/carbon/user/mgt/UserRealmProxy.java

Thanks.
Ajith.



On Mon, Jul 29, 2013 at 10:44 PM, Ajith Vitharana <aji...@wso2.com> wrote:

> I'm getting following error running registry tests with the latest build.
> Please fix this. We still can't build a stable pack to fix test failures.
> :(
>
> Thanks
> Ajith.
>
>
> TID: [0] [Greg] [2013-07-29 22:14:00,719] ERROR
> {org.wso2.carbon.user.core.util.DatabaseUtil} -  Using sql : INSERT INTO
> UM_USER_ROLE (UM_USER_ID, UM_ROLE_ID, UM_TENANT_ID) VALUES ((SELECT UM_ID
> FROM UM_USER WHERE UM_USER_NAME=? AND UM_TENANT_ID=?),(SELECT UM_ID FROM
> UM_ROLE WHERE UM_ROLE_NAME=? AND UM_TENANT_ID=?), ?)
> {org.wso2.carbon.user.core.util.DatabaseUtil}
> TID: [0] [Greg] [2013-07-29 22:14:00,723] ERROR
> {org.wso2.carbon.user.mgt.UserRealmProxy} -  Unique index or primary key
> violation: "CONSTRAINT_INDEX_BA ON PUBLIC.UM_USER_ROLE(UM_USER_ID,
> UM_ROLE_ID, UM_TENANT_ID)"; SQL statement:
> INSERT INTO UM_USER_ROLE (UM_USER_ID, UM_ROLE_ID, UM_TENANT_ID) VALUES
> ((SELECT UM_ID FROM UM_USER WHERE UM_USER_NAME=? AND UM_TENANT_ID=?),(SELECT
> UM_ID FROM UM_ROLE WHERE UM_ROLE_NAME=? AND UM_TENANT_ID=?), ?) [23001-140]
> {org.wso2.carbon.user.mgt.UserRealmProxy}
> org.wso2.carbon.user.core.UserStoreException: Unique index or primary key
> violation: "CONSTRAINT_INDEX_BA ON PUBLIC.UM_USER_ROLE(UM_USER_ID,
> UM_ROLE_ID, UM_TENANT_ID)"; SQL statement:
> INSERT INTO UM_USER_ROLE (UM_USER_ID, UM_ROLE_ID, UM_TENANT_ID) VALUES
> ((SELECT UM_ID FROM UM_USER WHERE UM_USER_NAME=? AND UM_TENANT_ID=?),(SELECT
> UM_ID FROM UM_ROLE WHERE UM_ROLE_NAME=? AND UM_TENANT_ID=?), ?) [23001-140]
>  
> atorg.wso2.carbon.user.core.jdbc.JDBCUserStoreManager.doUpdateUserListOfRole(JDBCUserStoreManager.java:1592)
> atorg.wso2.carbon.user.core.common.AbstractUserStoreManager.updateUserListOfRole(AbstractUserStoreManager.java:1085)
>  
> atorg.wso2.carbon.user.mgt.UserRealmProxy.updateUsersOfRole(UserRealmProxy.java:1466)
> atorg.wso2.carbon.user.mgt.UserAdmin.updateUsersOfRole(UserAdmin.java:419)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  at sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:39)
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:25)
>  at java.lang.reflect.Method.invoke(Method.java:597)
>  at org.apache.axis2.rpc.receivers.RPCUtil.invokeServiceClass(RPCUtil.java
> :212)
>  at org.apache.axis2.rpc.receivers.RPCMessageReceiver.invokeBusinessLogic(
> RPCMessageReceiver.java:117)
>  at org.apache.axis2.receivers.AbstractInOutMessageReceiver.
> invokeBusinessLogic(AbstractInOutMessageReceiver.java:40)
>  at org.apache.axis2.receivers.AbstractMessageReceiver.receive(
> AbstractMessageReceiver.java:110)
>  at org.apache.axis2.engine.AxisEngine.receive(AxisEngine.java:180)
>  
> atorg.apache.axis2.transport.http.HTTPTransportUtils.processHTTPPostRequest(HTTPTransportUtils.java:172)
> at org.apache.axis2.transport.http.AxisServlet.doPost(AxisServlet.java:
> 146)
>  at org.wso2.carbon.core.transports.CarbonServlet.doPost(
> CarbonServlet.java:231)
>  at javax.servlet.http.HttpServlet.service(HttpServlet.java:755)
>  at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
>  at org.eclipse.equinox.http.servlet.internal.ServletRegistration.service(
> ServletRegistration.java:61)
>  
> atorg.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:128)
> at org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(
> ProxyServlet.java:68)
>  at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
>  at org.wso2.carbon.tomcat.ext.servlet.DelegationServlet.service(
> DelegationServlet.java:68)
>  at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:305)
>  at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:210)
>  at
> org.wso2.carbon.tomcat.ext.filter.CharacterSetFilter.doFilter(CharacterSetFilter.java:61)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:243)
>  at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:210)
>  at org.apache.catalina.core.StandardWrapperValve.invoke(
> StandardWrapperValve.java:222)
>  at org.apache.catalina.core.StandardContextValve.invoke(
> StandardContextValve.java:123)
>  at org.apache.catalina.authenticator.AuthenticatorBase.invoke(
> AuthenticatorBase.java:472)
>  at org.apache.catalina.core.StandardHostValve.invoke(
> StandardHostValve.java:171)
>  at org.apache.catalina.valves.ErrorReportValve.invoke(
> ErrorReportValve.java:99)
>  at org.wso2.carbon.tomcat.ext.valves.CompositeValve.continueInvocation(
> CompositeValve.java:178)
>  at org.wso2.carbon.tomcat.ext.valves.CarbonTomcatValve$1.invoke(
> CarbonTomcatValve.java:47)
>  at org.wso2.carbon.webapp.mgt.TenantLazyLoaderValve.invoke(
> TenantLazyLoaderValve.java:56)
>  at org.wso2.carbon.apimgt.interceptor.valve.APIManagerInterceptorValve.
> invoke(APIManagerInterceptorValve.java:97)
>  at org.wso2.carbon.tomcat.ext.valves.TomcatValveContainer.invokeValves(
> TomcatValveContainer.java:47)
>  at org.wso2.carbon.tomcat.ext.valves.CompositeValve.invoke(
> CompositeValve.java:141)
>  at org.wso2.carbon.tomcat.ext.valves.CarbonStuckThreadDetectionValve.
> invoke(CarbonStuckThreadDetectionValve.java:156)
>  at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:
> 936)
>  at org.wso2.carbon.tomcat.ext.valves.CarbonContextCreatorValve.invoke(
> CarbonContextCreatorValve.java:52)
>  at org.apache.catalina.core.StandardEngineValve.invoke(
> StandardEngineValve.java:118)
>  at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java
> :407)
>  
> atorg.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)
> atorg.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
>  
> atorg.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653)
> at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(
> ThreadPoolExecutor.java:895)
>  at java.util.concurrent.ThreadPoolExecutor$Worker.run(
> ThreadPoolExecutor.java:918)
>  at java.lang.Thread.run(Thread.java:662)
> Caused by: org.wso2.carbon.user.core.UserStoreException: Unique index or
> primary key violation: "CONSTRAINT_INDEX_BA ON PUBLIC.UM_USER_ROLE(UM_USER_ID,
> UM_ROLE_ID, UM_TENANT_ID)"; SQL statement:
> INSERT INTO UM_USER_ROLE (UM_USER_ID, UM_ROLE_ID, UM_TENANT_ID) VALUES
> ((SELECT UM_ID FROM UM_USER WHERE UM_USER_NAME=? AND UM_TENANT_ID=?),(SELECT
> UM_ID FROM UM_ROLE WHERE UM_ROLE_NAME=? AND UM_TENANT_ID=?), ?) [23001-140]
>  
> atorg.wso2.carbon.user.core.util.DatabaseUtil.udpateUserRoleMappingInBatchMode(DatabaseUtil.java:515)
> atorg.wso2.carbon.user.core.jdbc.JDBCUserStoreManager.doUpdateUserListOfRole(JDBCUserStoreManager.java:1577)
>  ... 49 more
> Caused by: org.h2.jdbc.JdbcBatchUpdateException: Unique index or primary
> key violation: "CONSTRAINT_INDEX_BA ON PUBLIC.UM_USER_ROLE(UM_USER_ID,
> UM_ROLE_ID, UM_TENANT_ID)"; SQL statement:
> INSERT INTO UM_USER_ROLE (UM_USER_ID, UM_ROLE_ID, UM_TENANT_ID) VALUES
> ((SELECT UM_ID FROM UM_USER WHERE UM_USER_NAME=? AND UM_TENANT_ID=?),(SELECT
> UM_ID FROM UM_ROLE WHERE UM_ROLE_NAME=? AND UM_TENANT_ID=?), ?) [23001-140]
>  at org.h2.jdbc.JdbcPreparedStatement.executeBatch(
> JdbcPreparedStatement.java:1098)
>  
> atorg.wso2.carbon.user.core.util.DatabaseUtil.udpateUserRoleMappingInBatchMode(DatabaseUtil.java:504)
> ... 50 more
>
>
> --
> Ajith Vitharana.
> WSO2 Inc. - http://wso2.org
> Email  :  aji...@wso2.com
> Mobile : +94772217350
>
>


-- 
Ajith Vitharana.
WSO2 Inc. - http://wso2.org
Email  :  aji...@wso2.com
Mobile : +94772217350
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to