*Code review notes for Siddhi Event Tables*

Participants : Anjana, Suho, Lasantha, Rajeev ,Mohan


   - Use proper parameter names in methods
   - Remove custom db pooling code and use the inbuilt pooling
   - Just use sql datasource without having separate siddhiDataSource
   - An option for user to create the table by giving the query
   - Intelligently map the values for table attributes without  blindly map
   the attributes
   - Comment codes as much as possible

@Suho, Lasantha & Rajeev : Please add if i missed anything..

Regards,
Mohan



On Mon, Aug 12, 2013 at 5:08 PM, Rajeev Sampath <raje...@wso2.com> wrote:

> more details 
> »<https://www.google.com/calendar/event?action=VIEW&eid=bDRkaWgwamxraDBtdDF1Mm92Mzh2dGkxcjggbW9oYW5Ad3NvMi5jb20&tok=MTYjcmFqZWV2c0B3c28yLmNvbWVmYTlkODU2OTg2MzZiNjUzZGZmOWVlOGRlZjcwNDU3N2RkYWQzOTU&ctz=Asia/Colombo&hl=en>
> Code review - Siddhi event tables
> Code review for the persistence event tables in Siddhi.
> *When*
> ********Tue Aug 13, 2013 3pm – 4pm Colombo
> *Where*
> LK #58 4th Floor Meeting room 
> (map<http://maps.google.lk/maps?q=LK+%2358+4th+Floor+Meeting+room&hl=en>
> )
> *Calendar*
> mo...@wso2.com
> *Who*
> •
> Rajeev Sampath - organizer
> •
> Lasantha Fernando
> •
> Prabath Abeysekera
> •
> Sriskandarajah Suhothayan
> •
> Mohanadarshan Vivekanandalingam
> •
> Anjana Fernando
>
> Going?   
> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=bDRkaWgwamxraDBtdDF1Mm92Mzh2dGkxcjggbW9oYW5Ad3NvMi5jb20&rst=1&tok=MTYjcmFqZWV2c0B3c28yLmNvbWVmYTlkODU2OTg2MzZiNjUzZGZmOWVlOGRlZjcwNDU3N2RkYWQzOTU&ctz=Asia/Colombo&hl=en>-
> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=bDRkaWgwamxraDBtdDF1Mm92Mzh2dGkxcjggbW9oYW5Ad3NvMi5jb20&rst=3&tok=MTYjcmFqZWV2c0B3c28yLmNvbWVmYTlkODU2OTg2MzZiNjUzZGZmOWVlOGRlZjcwNDU3N2RkYWQzOTU&ctz=Asia/Colombo&hl=en>-
> No<https://www.google.com/calendar/event?action=RESPOND&eid=bDRkaWgwamxraDBtdDF1Mm92Mzh2dGkxcjggbW9oYW5Ad3NvMi5jb20&rst=2&tok=MTYjcmFqZWV2c0B3c28yLmNvbWVmYTlkODU2OTg2MzZiNjUzZGZmOWVlOGRlZjcwNDU3N2RkYWQzOTU&ctz=Asia/Colombo&hl=en>
> *    **more options 
> »<https://www.google.com/calendar/event?action=VIEW&eid=bDRkaWgwamxraDBtdDF1Mm92Mzh2dGkxcjggbW9oYW5Ad3NvMi5jb20&tok=MTYjcmFqZWV2c0B3c28yLmNvbWVmYTlkODU2OTg2MzZiNjUzZGZmOWVlOGRlZjcwNDU3N2RkYWQzOTU&ctz=Asia/Colombo&hl=en>
>
> Invitation from Google Calendar <https://www.google.com/calendar/>
>
> You are receiving this email at the account mo...@wso2.com because you
> are subscribed for invitations on calendar mo...@wso2.com.
>
> To stop receiving these notifications, please log in to
> https://www.google.com/calendar/ and change your notification settings
> for this calendar.
>



-- 
*V. Mohanadarshan*
*Software Engineer,*
*Data Technologies Team,*
*WSO2, Inc. http://wso2.com *
*lean.enterprise.middleware.*
*
*
email: mo...@wso2.com
phone:(+94) 771117673
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to