Sequence stub change reverted at r182434. Temporary fix for preventing compilation failures in sequence editor ui done at r181662 reverted at r182435. Automation test framework changes done for preventing compilation failures reverted at r182436. Automation test changes done for preventing compilation failures reverted at r182437
On Wed, Aug 21, 2013 at 11:25 PM, Kasun Indrasiri <ka...@wso2.com> wrote: > ESB 4.8 release work is affected by this and hence we are reverting these > changes. > Lets fix this properly and once everything works smoothly, then only we > can commit it back. > > > On Wed, Aug 21, 2013 at 8:09 PM, Isuru Udana <isu...@wso2.com> wrote: > >> Hi Ratha, >> >> Did you able to resolve this issue ? >> If not please revert your changes until you find a proper solution for >> this. >> This has become a absolute blocker for us. >> Because of this issue we were using a patched pack and reverting some >> commits locally for last couple of days and we cannot live with that >> anymore. >> Please do your changes in a way that no functional breaks at the ESB >> level. >> >> >> >> >> >> On Wed, Aug 21, 2013 at 9:30 AM, Kasun Indrasiri <ka...@wso2.com> wrote: >> >>> Please revert back these changes till we get a proper fix. Because of >>> this change, ESB integration tests are failing all over.. >>> >>> >>> On Mon, Aug 19, 2013 at 4:13 PM, Isuru Udana <isu...@wso2.com> wrote: >>> >>>> Hi All, >>>> >>>> Root cause of this issue is stub change done at r181488. >>>> Sequence Editor UI/sequence admin service is broken due to change. >>>> >>>> @ratha, >>>> Can you please revert this commit until this is fixed properly. We are >>>> getting lot of integration test failures due to this. >>>> >>>> >>>> Thanks. >>>> >>>> >>>> >>>> >>>> >>>> On Sat, Aug 17, 2013 at 1:44 PM, Krishantha Samaraweera < >>>> krishan...@wso2.com> wrote: >>>> >>>>> Test framework API is also broken due to the above reason. I have >>>>> temporary fixed it. >>>>> >>>>> Thanks, >>>>> Krishantha. >>>>> >>>>> >>>>> On Sat, Aug 17, 2013 at 12:45 PM, Vanjikumaran Sivajothy < >>>>> va...@wso2.com> wrote: >>>>> >>>>>> Hi dushan, >>>>>> >>>>>> I had a look on it, this was there form 4.0.0!! >>>>>> >>>>>> >>>>>> https://svn.wso2.org/repos/wso2/carbon/platform/branches/4.0.0/components/sequence-editor/org.wso2.carbon.sequences.ui/4.0.0/src/main/java/org/wso2/carbon/sequences/ui/client/SequenceAdminClient.java >>>>>> >>>>>> >>>>>> https://svn.wso2.org/repos/wso2/carbon/platform/branches/4.0.0/components/sequence-editor/org.wso2.carbon.sequences/4.0.0/src/main/java/org/wso2/carbon/sequences/services/SequenceAdmin.java >>>>>> >>>>>> Nevertheless, I will review it what goes wrong! >>>>>> >>>>>> >>>>>> >>>>>> On Sat, Aug 17, 2013 at 12:08 AM, Dushan Abeyruwan >>>>>> <dus...@wso2.com>wrote: >>>>>> >>>>>>> Hi >>>>>>> I did fix please take update in /sequence-editor/ >>>>>>> org.wso2.carbon.sequences.ui/4.2.0 >>>>>>> >>>>>>> >>>>>>> >>>>>>> btw Vanji, >>>>>>> please review the commit at the sequence-editor module which has >>>>>>> been broken due to some of the latest changers prior to my commit, >>>>>>> anyway >>>>>>> please check why it returns object instead of OMElement, you have the >>>>>>> best >>>>>>> reason since you worked for this module recently.. >>>>>>> >>>>>>> >>>>>>> Modified: carbon/platform/trunk/components/sequence-editor/ >>>>>>> org.wso2.carbon.sequences.ui/src/main/java/org/wso2/carbon/ >>>>>>> sequences/ui/client/SequenceAdminClient.java >>>>>>> =================================================================== >>>>>>> --- carbon/platform/trunk/components/sequence-editor/ >>>>>>> org.wso2.carbon.sequences.ui/src/main/java/org/wso2/carbon/ >>>>>>> sequences/ui/client/SequenceAdminClient.java 2013-08-16 18:28:11 >>>>>>> UTC (rev 181653) >>>>>>> +++ carbon/platform/trunk/components/sequence-editor/ >>>>>>> org.wso2.carbon.sequences.ui/src/main/java/org/wso2/carbon/ >>>>>>> sequences/ui/client/SequenceAdminClient.java 2013-08-16 18:30:35 >>>>>>> UTC (rev 181654) >>>>>>> @@ -145,7 +145,7 @@ >>>>>>> private OMElement getSequence(String sequenceName) throws >>>>>>> SequenceEditorException { >>>>>>> OMElement element = null; >>>>>>> try { >>>>>>> - element = sequenceAdminStub.getSequence( >>>>>>> sequenceName).getFirstElement(); >>>>>>> + element = ((OMElement)(sequenceAdminStub.getSequence( >>>>>>> sequenceName))).getFirstElement(); >>>>>>> } catch (Exception e) { >>>>>>> handleException("Couldn't retrieve the sequence element >>>>>>> with name '" >>>>>>> + sequenceName + "'", e); >>>>>>> @@ -197,7 +197,7 @@ >>>>>>> public OMElement getDynamicSequence(String key) throws >>>>>>> SequenceEditorException { >>>>>>> OMElement dynamicSequence = null; >>>>>>> try { >>>>>>> - dynamicSequence = sequenceAdminStub. >>>>>>> getDynamicSequence(key); >>>>>>> + dynamicSequence = (OMElement)sequenceAdminStub. >>>>>>> getDynamicSequence(key); >>>>>>> } catch (Exception e) { >>>>>>> handleException("Couldn't get dynamic sequence with key >>>>>>> '" + key + "'", e); >>>>>>> } >>>>>>> >>>>>>> >>>>>>> On Fri, Aug 16, 2013 at 11:36 PM, Shameera Rathnayaka < >>>>>>> shame...@wso2.com> wrote: >>>>>>> >>>>>>>> Hi ESB team, >>>>>>>> >>>>>>>> This will lead to many build failures in mediator module, Please >>>>>>>> consider this as urgent issue. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Shameera. >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Aug 16, 2013 at 10:10 PM, Shameera Rathnayaka < >>>>>>>> shame...@wso2.com> wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> Please fix the $subject. >>>>>>>>> >>>>>>>>> >>>>>>>>> [INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ >>>>>>>>> org.wso2.carbon.sequences.ui --- >>>>>>>>> [INFO] Compiling 12 source files to >>>>>>>>> /build/branches/platform/components/sequence-editor/org.wso2.carbon.sequences.ui/4.2.0/target/classes >>>>>>>>> [INFO] >>>>>>>>> ------------------------------------------------------------- >>>>>>>>> [ERROR] COMPILATION ERROR : >>>>>>>>> [INFO] >>>>>>>>> ------------------------------------------------------------- >>>>>>>>> [ERROR] >>>>>>>>> /build/branches/platform/components/sequence-editor/org.wso2.carbon.sequences.ui/4.2.0/src/main/java/org/wso2/carbon/sequences/ui/client/SequenceAdminClient.java:[148,65] >>>>>>>>> cannot find symbol >>>>>>>>> symbol : method getFirstElement() >>>>>>>>> location: class java.lang.Object >>>>>>>>> [ERROR] >>>>>>>>> /build/branches/platform/components/sequence-editor/org.wso2.carbon.sequences.ui/4.2.0/src/main/java/org/wso2/carbon/sequences/ui/client/SequenceAdminClient.java:[200,66] >>>>>>>>> incompatible types >>>>>>>>> found : java.lang.Object >>>>>>>>> required: org.apache.axiom.om.OMElement >>>>>>>>> [INFO] 2 errors >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Shameera. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Software Engineer - WSO2 Inc.* >>>>>>>>> *email: shameera AT wso2.com <shame...@wso2.com> , shameera AT >>>>>>>>> apache.org <shame...@apache.org>* >>>>>>>>> *phone: +9471 922 1454* >>>>>>>>> * >>>>>>>>> * >>>>>>>>> *Linked in : * >>>>>>>>> http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 >>>>>>>>> *Twitter : *https://twitter.com/Shameera_R >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Software Engineer - WSO2 Inc.* >>>>>>>> *email: shameera AT wso2.com <shame...@wso2.com> , shameera AT >>>>>>>> apache.org <shame...@apache.org>* >>>>>>>> *phone: +9471 922 1454* >>>>>>>> * >>>>>>>> * >>>>>>>> *Linked in : * >>>>>>>> http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 >>>>>>>> *Twitter : *https://twitter.com/Shameera_R >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dushan Abeyruwan >>>>>>> Associate Tech Lead >>>>>>> *Integration Technologies Team* >>>>>>> *WSO2 Inc. http://wso2.com/* >>>>>>> *Mobile:(+94)714408632* >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sivajothy Vanjikumaran >>>>>> *Senior Software Engineer* >>>>>> *Integration Technologies Team* >>>>>> *WSO2 Inc. http://wso2.com/* >>>>>> *Mobile:(+94)777219209** >>>>>> *[image: Facebook] <https://www.facebook.com/vanjikumaran> [image: >>>>>> Twitter] <https://twitter.com/vanjikumaran> [image: >>>>>> LinkedIn]<http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> >>>>>> [image: >>>>>> Blogger] <http://vanjikumaran.blogspot.com/> [image: >>>>>> SlideShare]<http://www.slideshare.net/vanjikumaran> >>>>>> >>>>>> _______________________________________________ >>>>>> Dev mailing list >>>>>> Dev@wso2.org >>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>> >>>>>> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> Dev@wso2.org >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Isuru Udana* >>>> * >>>> * >>>> Senior * >>>> Software Engineer >>>> * >>>> WSO2 Inc.; http://wso2.com >>>> email: isu...@wso2.com cell: +94 77 3791887 >>>> blog: http://mytecheye.blogspot.com/ >>>> twitter: http://twitter.com/isudana >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Kasun Indrasiri >>> Software Architect >>> WSO2, Inc.; http://wso2.com >>> lean.enterprise.middleware >>> >>> cell: +94 71 536 4128 >>> Blog : http://kasunpanorama.blogspot.com/ >>> >> >> >> >> -- >> *Isuru Udana* >> * >> * >> Senior * >> Software Engineer >> * >> WSO2 Inc.; http://wso2.com >> email: isu...@wso2.com cell: +94 77 3791887 >> blog: http://mytecheye.blogspot.com/ >> twitter: http://twitter.com/isudana >> > > > > -- > Kasun Indrasiri > Software Architect > WSO2, Inc.; http://wso2.com > lean.enterprise.middleware > > cell: +94 71 536 4128 > Blog : http://kasunpanorama.blogspot.com/ > -- *Isuru Udana* * * Senior * Software Engineer * WSO2 Inc.; http://wso2.com email: isu...@wso2.com cell: +94 77 3791887 blog: http://mytecheye.blogspot.com/ twitter: http://twitter.com/isudana
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
